From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch,
jiri@resnulli.us, mkubecek@suse.cz, dsahern@kernel.org,
pablo@netfilter.org
Subject: Re: [PATCH net-next v2 00/10] genetlink: support per-command policy dump
Date: Fri, 02 Oct 2020 17:04:11 +0200 [thread overview]
Message-ID: <a69c92aac65c718b1bd80c8dc0cbb471cdd17d9b.camel@sipsolutions.net> (raw)
In-Reply-To: <20201002080308.7832bcc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, 2020-10-02 at 08:03 -0700, Jakub Kicinski wrote:
> > Huh, I even CC'ed you I think?
>
> I filter stuff which is to:netdev cc:me and get to it when I read the
> ML. There's too much of it.
Ah, ok :)
> > Yeah, that'd work. I'd probably wonder if we shouldn't do
> >
> > [OP_POLICY]
> > [OP] -> (u32, u32)
> >
> > in a struct with two u32's, since that's quite a bit more compact.
>
> What do we do if the op doesn't have a dump or do callback?
> 0 is a valid policy ID, sadly :(
Hm, good point. We could do -1 since that can't ever be reached though.
But compactness isn't really that necessary here anyway, so ...
johannes
next prev parent reply other threads:[~2020-10-02 15:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 22:59 [PATCH net-next v2 00/10] genetlink: support per-command policy dump Jakub Kicinski
2020-10-01 22:59 ` [PATCH net-next v2 01/10] genetlink: reorg struct genl_family Jakub Kicinski
2020-10-01 22:59 ` [PATCH net-next v2 02/10] genetlink: add small version of ops Jakub Kicinski
2020-10-01 22:59 ` [PATCH net-next v2 03/10] genetlink: move to smaller ops wherever possible Jakub Kicinski
2020-10-01 22:59 ` [PATCH net-next v2 04/10] genetlink: add a structure for dump state Jakub Kicinski
2020-10-01 22:59 ` [PATCH net-next v2 05/10] genetlink: use .start callback for dumppolicy Jakub Kicinski
2020-10-01 22:59 ` [PATCH net-next v2 06/10] genetlink: bring back per op policy Jakub Kicinski
2020-10-01 22:59 ` [PATCH net-next v2 07/10] taskstats: move specifying netlink policy back to ops Jakub Kicinski
2020-10-01 22:59 ` [PATCH net-next v2 08/10] genetlink: use parsed attrs in dumppolicy Jakub Kicinski
2020-10-02 6:30 ` Johannes Berg
2020-10-01 22:59 ` [PATCH net-next v2 09/10] genetlink: switch control commands to per-op policies Jakub Kicinski
2020-10-02 6:33 ` Johannes Berg
2020-10-01 22:59 ` [PATCH net-next v2 10/10] genetlink: allow dumping command-specific policy Jakub Kicinski
2020-10-02 6:34 ` Johannes Berg
2020-10-02 0:36 ` [PATCH net-next v2 00/10] genetlink: support per-command policy dump Jakub Kicinski
2020-10-02 6:29 ` Johannes Berg
2020-10-02 14:40 ` Jakub Kicinski
2020-10-02 14:42 ` Johannes Berg
2020-10-02 14:55 ` Jakub Kicinski
2020-10-02 14:58 ` Johannes Berg
2020-10-02 15:03 ` Jakub Kicinski
2020-10-02 15:04 ` Johannes Berg [this message]
2020-10-02 15:09 ` Jakub Kicinski
2020-10-02 15:13 ` Johannes Berg
2020-10-02 15:25 ` Jakub Kicinski
2020-10-02 15:28 ` Johannes Berg
2020-10-02 16:55 ` Michal Kubecek
2020-10-02 20:07 ` David Miller
2020-10-02 20:27 ` Johannes Berg
2020-10-02 20:50 ` Jakub Kicinski
2020-10-02 20:59 ` Johannes Berg
2020-10-02 21:00 ` Johannes Berg
2020-10-02 21:17 ` Jakub Kicinski
2020-10-02 21:22 ` Jakub Kicinski
2020-10-02 21:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a69c92aac65c718b1bd80c8dc0cbb471cdd17d9b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).