From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 00/18] ipv6: Align nexthop behaviour with IPv4 Date: Tue, 9 Jan 2018 21:41:11 -0700 Message-ID: References: <20180107104518.31693-1-idosch@mellanox.com> <5c10b955-161d-9cb1-edd1-7a49d88e46ad@gmail.com> <20180109080424.GA6699@splinter> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Ido Schimmel , netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, nicolas.dichtel@6wind.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org, mlxsw@mellanox.com To: Ido Schimmel Return-path: Received: from mail-io0-f172.google.com ([209.85.223.172]:45073 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757260AbeAJElO (ORCPT ); Tue, 9 Jan 2018 23:41:14 -0500 Received: by mail-io0-f172.google.com with SMTP id e20so20950671iof.12 for ; Tue, 09 Jan 2018 20:41:14 -0800 (PST) In-Reply-To: <20180109080424.GA6699@splinter> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/9/18 1:04 AM, Ido Schimmel wrote: > On Sun, Jan 07, 2018 at 10:20:11AM -0700, David Ahern wrote: >> One of many follow on changes that would be beneficial is to remove the >> idev dereference in the hot path to check the >> ignore_routes_with_linkdown sysctl. > > When a netdev loses its carrier we can set the RTNH_F_DEAD flag for all > the nexthops using it as their nexthop device, in case the sysctl is > set. Similarly, when the sysctl is toggled we can walk the routing > tables and toggle the flag where appropriate. > > You have a different idea? that would work.