From: Jiri Benc <jbenc@redhat.com>
To: netdev@vger.kernel.org
Cc: Thomas Graf <tgraf@suug.ch>, Wei-Chun Chao <weichunc@plumgrid.com>
Subject: [PATCH v3 net-next 07/13] ipv6: drop metadata dst in ip6_route_input
Date: Thu, 20 Aug 2015 13:56:26 +0200 [thread overview]
Message-ID: <a6ec60f8a70a710f8a92f723ec4bd1016ea4ea22.1440071726.git.jbenc@redhat.com> (raw)
In-Reply-To: <cover.1440071726.git.jbenc@redhat.com>
The fix in commit 48fb6b554501 is incomplete, as now ip6_route_input can be
called with non-NULL dst if it's a metadata dst and the reference is leaked.
Drop the reference.
Fixes: 48fb6b554501 ("ipv6: fix crash over flow-based vxlan device")
Fixes: ee122c79d422 ("vxlan: Flow based tunneling")
CC: Wei-Chun Chao <weichunc@plumgrid.com>
CC: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Jiri Benc <jbenc@redhat.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
---
net/ipv6/route.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index e6bbcdee7707..0947ad0b3de8 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -1140,6 +1140,7 @@ void ip6_route_input(struct sk_buff *skb)
.flowi6_proto = iph->nexthdr,
};
+ skb_dst_drop(skb);
skb_dst_set(skb, ip6_route_input_lookup(net, skb->dev, &fl6, flags));
}
--
1.8.3.1
next prev parent reply other threads:[~2015-08-20 11:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 11:56 [PATCH v3 net-next 00/13] lwtunnel: per route ipv6 support for vxlan Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 01/13] ip_tunnels: remove custom alignment and packing Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 02/13] ip_tunnels: use u8/u16/u32 Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 03/13] ip_tunnels: use offsetofend Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 04/13] ip_tunnels: add IPv6 addresses to ip_tunnel_key Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 05/13] ip_tunnels: use tos and ttl fields also for IPv6 Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 06/13] route: move lwtunnel state to dst_entry Jiri Benc
2015-08-20 11:56 ` Jiri Benc [this message]
2015-08-20 11:56 ` [PATCH v3 net-next 08/13] ipv6: ndisc: inherit metadata dst when creating ndisc requests Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 09/13] vxlan: provide access function for vxlan socket address family Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 10/13] vxlan: do not shadow flags variable Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 11/13] vxlan: metadata based tunneling for IPv6 Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 12/13] ipv6: route: extend flow representation with tunnel key Jiri Benc
2015-08-20 11:56 ` [PATCH v3 net-next 13/13] ipv6: route: per route IP tunnel metadata via lightweight tunnel Jiri Benc
2015-08-20 22:42 ` [PATCH v3 net-next 00/13] lwtunnel: per route ipv6 support for vxlan David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ec60f8a70a710f8a92f723ec4bd1016ea4ea22.1440071726.git.jbenc@redhat.com \
--to=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=weichunc@plumgrid.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).