From: Hayes Wang <hayeswang@realtek.com>
To: Grant Grundler <grundler@chromium.org>,
Doug Anderson <dianders@chromium.org>
Cc: "Jakub Kicinski" <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Simon Horman" <horms@kernel.org>,
"Edward Hill" <ecgh@chromium.org>,
"Laura Nao" <laura.nao@collabora.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"Bjørn Mork" <bjorn@mork.no>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v3 5/5] r8152: Block future register access if register access fails
Date: Wed, 18 Oct 2023 12:01:02 +0000 [thread overview]
Message-ID: <a6f10400c04d48fbaa419310c0ae71de@realtek.com> (raw)
In-Reply-To: <CANEJEGuEdGUAUufEHBfxbo_thXbgr8gMFVBaa+pCV_axWO=NGQ@mail.gmail.com>
Grant Grundler <grundler@chromium.org>
> Sent: Wednesday, October 18, 2023 2:06 PM
[...]
> Hayes,
> As Doug points out the probability is really low of this happening for
> an event that is already rare. Doug's patch is a very good step in the
> right direction (driver robustness) and I think has been tested by
> Chromium OS team enough that it is safe to apply to the upstream tree.
> I'm a big fan of taking small steps where we can. We can further
> improve on this in the future as needed.
I don't reject the patch. And, I don't have the right to reject or apply the patch.
I just don't wish the patch to trouble the others. And, I need the professional
people to check me views, too.
I think someone would determine whether the patch could be applied, or not.
Best Regards,
Hayes
> Please add:
> Reviewed-by: Grant Grundler <grundler@chromium.org>
>
> cheers,
> grant
>
> >
> > -Doug
next prev parent reply other threads:[~2023-10-18 12:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 19:24 [PATCH v3 0/5] r8152: Avoid writing garbage to the adapter's registers Douglas Anderson
2023-10-12 19:25 ` [PATCH v3 1/5] r8152: Increase USB control msg timeout to 5000ms as per spec Douglas Anderson
2023-10-12 19:25 ` [PATCH v3 2/5] r8152: Check for unplug in rtl_phy_patch_request() Douglas Anderson
2023-10-12 19:25 ` [PATCH v3 3/5] r8152: Check for unplug in r8153b_ups_en() / r8153c_ups_en() Douglas Anderson
2023-10-12 19:25 ` [PATCH v3 4/5] r8152: Rename RTL8152_UNPLUG to RTL8152_INACCESSIBLE Douglas Anderson
2023-10-12 19:25 ` [PATCH v3 5/5] r8152: Block future register access if register access fails Douglas Anderson
2023-10-16 9:15 ` Hayes Wang
2023-10-16 16:46 ` Doug Anderson
2023-10-17 13:07 ` Hayes Wang
2023-10-17 14:17 ` Doug Anderson
2023-10-17 18:37 ` Doug Anderson
2023-10-18 6:06 ` Grant Grundler
2023-10-18 12:01 ` Hayes Wang [this message]
2023-10-18 11:40 ` Hayes Wang
2023-10-19 15:41 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f10400c04d48fbaa419310c0ae71de@realtek.com \
--to=hayeswang@realtek.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=ecgh@chromium.org \
--cc=edumazet@google.com \
--cc=grundler@chromium.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=laura.nao@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).