From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Venkataramanan, Anirudh" <anirudh.venkataramanan@intel.com>,
"kubakici@wp.pl" <kubakici@wp.pl>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [PATCH 12/15] ice: Add stats and ethtool support
Date: Tue, 13 Mar 2018 12:17:10 -0700 [thread overview]
Message-ID: <a6f3bd20-705e-2022-23c8-1e3b5a8c93a6@gmail.com> (raw)
In-Reply-To: <1520967916.696.21.camel@intel.com>
On 03/13/2018 12:05 PM, Venkataramanan, Anirudh wrote:
> On Fri, 2018-03-09 at 15:14 -0800, Jakub Kicinski wrote:
>> On Fri, 9 Mar 2018 09:21:33 -0800, Anirudh Venkataramanan wrote:
>>> +static const struct ice_stats ice_net_stats[] = {
>>> + ICE_NETDEV_STAT(rx_packets),
>>> + ICE_NETDEV_STAT(tx_packets),
>>> + ICE_NETDEV_STAT(rx_bytes),
>>> + ICE_NETDEV_STAT(tx_bytes),
>>> + ICE_NETDEV_STAT(rx_errors),
>>> + ICE_NETDEV_STAT(tx_errors),
>>> + ICE_NETDEV_STAT(rx_dropped),
>>> + ICE_NETDEV_STAT(tx_dropped),
>>> + ICE_NETDEV_STAT(multicast),
>>> + ICE_NETDEV_STAT(rx_length_errors),
>>> + ICE_NETDEV_STAT(rx_crc_errors),
>>> +};
>>
>> Please don't duplicate standard netdev stats in ethtool -S.
>
> Jacub,
>
> Thanks for the feedback. I am not sure I understand what's being asked
> here. Do you mean to say that standard netdev stats should not be
> printed when we do ethtool -S or something else?
>
> Thanks!
> Ani
>
Yes, this is a recurring mistake
See commit
bf909456f6a89654cb65c01fe83a4f9b133bf978 Revert "net: hns3: Add packet
statistics of netdev"
next prev parent reply other threads:[~2018-03-13 19:17 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 17:21 [PATCH 00/15] Add ice driver Anirudh Venkataramanan
2018-03-09 17:21 ` [PATCH 01/15] ice: Add basic driver framework for Intel(R) E800 Series Anirudh Venkataramanan
2018-03-09 22:16 ` Jakub Kicinski
2018-03-12 16:56 ` [Intel-wired-lan] " Jeff Kirsher
2018-03-13 4:41 ` Jakub Kicinski
2018-03-09 17:21 ` [PATCH 02/15] ice: Add support for control queues Anirudh Venkataramanan
2018-03-13 2:05 ` [Intel-wired-lan] " Shannon Nelson
2018-03-14 22:16 ` Jeff Kirsher
2018-03-09 17:21 ` [PATCH 03/15] ice: Start hardware initialization Anirudh Venkataramanan
2018-03-13 2:05 ` [Intel-wired-lan] " Shannon Nelson
2018-03-14 22:05 ` Venkataramanan, Anirudh
2018-03-15 17:00 ` Shannon Nelson
2018-03-15 18:27 ` Venkataramanan, Anirudh
2018-03-09 17:21 ` [PATCH 04/15] ice: Get switch config, scheduler config and device capabilities Anirudh Venkataramanan
2018-03-13 2:05 ` [Intel-wired-lan] " Shannon Nelson
2018-03-09 17:21 ` [PATCH 05/15] ice: Get MAC/PHY/link info and scheduler topology Anirudh Venkataramanan
2018-03-09 17:21 ` [PATCH 06/15] ice: Initialize PF and setup miscellaneous interrupt Anirudh Venkataramanan
2018-03-13 2:05 ` [Intel-wired-lan] " Shannon Nelson
2018-03-09 17:21 ` [PATCH 07/15] ice: Add support for VSI allocation and deallocation Anirudh Venkataramanan
2018-03-13 2:05 ` [Intel-wired-lan] " Shannon Nelson
2018-03-09 17:21 ` [PATCH 08/15] ice: Add support for switch filter programming Anirudh Venkataramanan
2018-03-09 17:21 ` [PATCH 09/15] ice: Configure VSIs for Tx/Rx Anirudh Venkataramanan
2018-03-10 16:39 ` Stephen Hemminger
2018-03-09 17:21 ` [PATCH 10/15] ice: Implement transmit and NAPI support Anirudh Venkataramanan
2018-03-09 17:21 ` [PATCH 11/15] ice: Add support for VLANs and offloads Anirudh Venkataramanan
2018-03-09 17:21 ` [PATCH 12/15] ice: Add stats and ethtool support Anirudh Venkataramanan
2018-03-09 18:14 ` Andrew Lunn
2018-03-09 23:14 ` Jakub Kicinski
2018-03-10 2:35 ` David Miller
2018-03-13 19:05 ` Venkataramanan, Anirudh
2018-03-13 19:17 ` Eric Dumazet [this message]
2018-03-13 21:14 ` [Intel-wired-lan] " Jesse Brandeburg
2018-03-13 21:44 ` Eric Dumazet
2018-03-14 1:30 ` Toshiaki Makita
2018-03-14 15:13 ` Stephen Hemminger
2018-03-13 20:54 ` David Miller
2018-03-10 16:37 ` Stephen Hemminger
2018-03-10 16:42 ` Stephen Hemminger
2018-03-13 20:42 ` Venkataramanan, Anirudh
2018-03-09 17:21 ` [PATCH 13/15] ice: Update Tx scheduler tree for VSI multi-Tx queue support Anirudh Venkataramanan
2018-03-09 17:21 ` [PATCH 14/15] ice: Support link events, reset and rebuild Anirudh Venkataramanan
2018-03-09 17:21 ` [PATCH 15/15] ice: Implement filter sync, NDO operations and bump version Anirudh Venkataramanan
2018-03-09 18:23 ` [PATCH 00/15] Add ice driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f3bd20-705e-2022-23c8-1e3b5a8c93a6@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=anirudh.venkataramanan@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).