From: David Laight <David.Laight@ACULAB.COM>
To: 'Marcelo Ricardo Leitner' <marcelo.leitner@gmail.com>
Cc: "'netdev@vger.kernel.org'" <netdev@vger.kernel.org>,
"'linux-sctp@vger.kernel.org'" <linux-sctp@vger.kernel.org>
Subject: RE: [PATCH] net: sctp: Fix negotiation of the number of data streams.
Date: Tue, 18 Aug 2020 22:10:44 +0000 [thread overview]
Message-ID: <a71c0fced85a4f0f98b954b37c3a76ae@AcuMS.aculab.com> (raw)
In-Reply-To: <20200818214648.GJ3399@localhost.localdomain>
From: 'Marcelo Ricardo Leitner'
> Sent: 18 August 2020 22:47
>
> On Tue, Aug 18, 2020 at 02:36:58PM +0000, David Laight wrote:
> > The number of streams offered by the remote system was being ignored.
> > Any data sent on those streams would get discarded by the remote system.
>
> That's quite brief and not accurate: it was only ignored if 'Xcnt <=
> stream->Xcnt'.
The number of streams (esp out ones) received from the remote
system in an INIT or INIT_ACK was ignored.
So it would always send data chunks using the number of streams
requested by the local user.
I managed to tweak our M3UA config to get invalid stream numbers
sent on both inwards and outwards connections.
I only noticed because of testing a (slightly horrid) workaround
for no longer being able to use kernel_getsockopt() to retrieve
the number of ostreams.
The number of ostreams was about the only thing we didn't trace :-(
At least my code can now obtain the correct value even for buggy
kernels.
> Other than this and the Fixes tag, LGTM. Passes the tests here. I'll
> ack the v2 then.
I wasn't sure whether DM actually wanted a V2 with the fixes
tag fixed.
I can send one tomorrow.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2020-08-18 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 14:36 [PATCH] net: sctp: Fix negotiation of the number of data streams David Laight
2020-08-18 19:58 ` David Miller
2020-08-18 21:28 ` David Laight
2020-08-18 21:46 ` 'Marcelo Ricardo Leitner'
2020-08-18 22:10 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a71c0fced85a4f0f98b954b37c3a76ae@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).