From: David Ahern <dsahern@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
syzbot <syzbot+2422c9e35796659d2273@syzkaller.appspotmail.com>,
davem@davemloft.net, kuznet@ms2.inr.ac.ru,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING: suspicious RCU usage in rt6_check_expired
Date: Mon, 23 Apr 2018 09:10:03 -0600 [thread overview]
Message-ID: <a73fcd37-b8f9-a340-7874-e83350b61879@gmail.com> (raw)
In-Reply-To: <a0eb8d30-0f76-fad2-e9fa-5de92f59b2ff@gmail.com>
On 4/23/18 7:31 AM, Eric Dumazet wrote:
>> stack backtrace:
>> CPU: 1 PID: 25958 Comm: syz-executor7 Not tainted 4.16.0+ #11
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
>> Call Trace:
>> __dump_stack lib/dump_stack.c:77 [inline]
>> dump_stack+0x1b9/0x294 lib/dump_stack.c:113
>> lockdep_rcu_suspicious+0x14a/0x153 kernel/locking/lockdep.c:4592
>> rt6_check_expired+0x38b/0x3e0 net/ipv6/route.c:410
>> ip6_negative_advice+0x67/0xc0 net/ipv6/route.c:2204
>> dst_negative_advice include/net/sock.h:1786 [inline]
>> sock_setsockopt+0x138f/0x1fe0 net/core/sock.c:1051
>> __sys_setsockopt+0x2df/0x390 net/socket.c:1899
>> SYSC_setsockopt net/socket.c:1914 [inline]
>> SyS_setsockopt+0x34/0x50 net/socket.c:1911
>> do_syscall_64+0x29e/0x9d0 arch/x86/entry/common.c:287
>> entry_SYSCALL_64_after_hwframe+0x42/0xb7
...
>
> Added in commit a68886a691804d3f6d479ebf6825480fbafb6a00
> ("net/ipv6: Make from in rt6_info rcu protected")
>
I missed the rcu_read_lock for this path. Will send a patch.
prev parent reply other threads:[~2018-04-23 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 8:24 WARNING: suspicious RCU usage in rt6_check_expired syzbot
2018-04-23 13:31 ` Eric Dumazet
2018-04-23 15:10 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a73fcd37-b8f9-a340-7874-e83350b61879@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+2422c9e35796659d2273@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).