From: Paolo Abeni <pabeni@redhat.com>
To: Willem de Bruijn <willemb@google.com>,
Andrei Gherzan <andrei.gherzan@canonical.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: net: udpgso_bench_tx: Introduce exponential back-off retries
Date: Mon, 30 Jan 2023 09:26:05 +0100 [thread overview]
Message-ID: <a762638b06684cd63d212d1ce9f65236a08b78b1.camel@redhat.com> (raw)
In-Reply-To: <CA+FuTSewU6bjYLsyLzZ1Yne=6YBPDJZ=U1mZc+6cJVdr06BhiQ@mail.gmail.com>
On Fri, 2023-01-27 at 17:03 -0500, Willem de Bruijn wrote:
> On Fri, Jan 27, 2023 at 1:16 PM Andrei Gherzan
> <andrei.gherzan@canonical.com> wrote:
> >
> > The tx and rx test programs are used in a couple of test scripts including
> > "udpgro_bench.sh". Taking this as an example, when the rx/tx programs
> > are invoked subsequently, there is a chance that the rx one is not ready to
> > accept socket connections. This racing bug could fail the test with at
> > least one of the following:
> >
> > ./udpgso_bench_tx: connect: Connection refused
> > ./udpgso_bench_tx: sendmsg: Connection refused
> > ./udpgso_bench_tx: write: Connection refused
> >
> > This change addresses this by adding routines that retry the socket
> > operations with an exponential back off algorithm from 100ms to 2s.
> >
> > Fixes: 3a687bef148d ("selftests: udp gso benchmark")
> > Signed-off-by: Andrei Gherzan <andrei.gherzan@canonical.com>
>
> Synchronizing the two processes is indeed tricky.
>
> Perhaps more robust is opening an initial TCP connection, with
> SO_RCVTIMEO to bound the waiting time. That covers all tests in one
> go.
Another option would be waiting for the listener(tcp)/receiver(udp)
socket to show up in 'ss' output before firing-up the client - quite
alike what mptcp self-tests are doing.
Cheers,
Paolo
next prev parent reply other threads:[~2023-01-30 8:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 18:16 [PATCH] selftests: net: udpgso_bench_tx: Introduce exponential back-off retries Andrei Gherzan
2023-01-27 22:03 ` Willem de Bruijn
2023-01-30 8:26 ` Paolo Abeni [this message]
2023-01-30 12:51 ` Andrei Gherzan
2023-01-30 13:35 ` Willem de Bruijn
2023-01-30 14:28 ` Andrei Gherzan
2023-01-30 16:03 ` Willem de Bruijn
2023-01-30 16:15 ` Andrei Gherzan
2023-01-30 16:23 ` Andrei Gherzan
2023-01-30 16:29 ` Willem de Bruijn
2023-01-30 17:31 ` Andrei Gherzan
2023-01-30 17:35 ` Willem de Bruijn
2023-01-30 18:24 ` Andrei Gherzan
2023-01-30 19:51 ` Andrei Gherzan
2023-01-30 19:57 ` Willem de Bruijn
2023-01-30 20:25 ` Andrei Gherzan
2023-01-31 13:10 ` Andrei Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a762638b06684cd63d212d1ce9f65236a08b78b1.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=andrei.gherzan@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).