From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Date: Mon, 21 May 2018 10:10:11 -0700 Message-ID: References: <20180518071753.4768-1-bhole_prashant_q7@lab.ntt.co.jp> <20180518071753.4768-3-bhole_prashant_q7@lab.ntt.co.jp> <4c7e3657-902e-016b-0604-eef3448ae3d5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , Shuah Khan , netdev@vger.kernel.org To: Prashant Bhole , Alexei Starovoitov , Daniel Borkmann Return-path: Received: from mail-it0-f68.google.com ([209.85.214.68]:38152 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061AbeEURK2 (ORCPT ); Mon, 21 May 2018 13:10:28 -0400 Received: by mail-it0-f68.google.com with SMTP id q4-v6so21950568ite.3 for ; Mon, 21 May 2018 10:10:28 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/20/2018 10:15 PM, Prashant Bhole wrote: > > > On 5/19/2018 1:45 AM, John Fastabend wrote: >> On 05/18/2018 12:17 AM, Prashant Bhole wrote: >>> In case of selftest mode, temporary cgroup environment is created but >>> cgroup is not joined. It causes test failures. Fixed by joining the >>> cgroup >>> >>> Fixes: 16962b2404ac ("bpf: sockmap, add selftests") >>> Signed-off-by: Prashant Bhole >>> -- >> >> Thanks, LGTM. Should this be the first patch in the series though? >> I wonder if after patch 1 if you would get failures without this >> patch. > > Patch 1 fixes selftest mode as well as manual mode. This patch 2 is > specifically for selftest mode, hence the sequence. > > - Prashant > > OK.