From: David Ahern <dsahern@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, horms@kernel.org, petrm@nvidia.com,
aroulin@nvidia.com
Subject: Re: [PATCH net 3/3] selftests: fib_nexthops: Add test cases for FDB status change
Date: Sun, 21 Sep 2025 09:39:29 -0600 [thread overview]
Message-ID: <a7b10e85-1201-4865-84c4-17e2d0971ac9@kernel.org> (raw)
In-Reply-To: <20250921150824.149157-4-idosch@nvidia.com>
On 9/21/25 9:08 AM, Ido Schimmel wrote:
> Add the following test cases for both IPv4 and IPv6:
>
> * Can change from FDB nexthop to non-FDB nexthop and vice versa.
> * Can change FDB nexthop address while in a group.
> * Cannot change from FDB nexthop to non-FDB nexthop and vice versa while
> in a group.
>
> Output without "nexthop: Forbid FDB status change while nexthop is in a
> group":
>
> # ./fib_nexthops.sh -t "ipv6_fdb_grp_fcnal ipv4_fdb_grp_fcnal"
>
> IPv6 fdb groups functional
> --------------------------
> [...]
> TEST: Replace FDB nexthop to non-FDB nexthop [ OK ]
> TEST: Replace non-FDB nexthop to FDB nexthop [ OK ]
> TEST: Replace FDB nexthop address while in a group [ OK ]
> TEST: Replace FDB nexthop to non-FDB nexthop while in a group [FAIL]
> TEST: Replace non-FDB nexthop to FDB nexthop while in a group [FAIL]
> [...]
>
> IPv4 fdb groups functional
> --------------------------
> [...]
> TEST: Replace FDB nexthop to non-FDB nexthop [ OK ]
> TEST: Replace non-FDB nexthop to FDB nexthop [ OK ]
> TEST: Replace FDB nexthop address while in a group [ OK ]
> TEST: Replace FDB nexthop to non-FDB nexthop while in a group [FAIL]
> TEST: Replace non-FDB nexthop to FDB nexthop while in a group [FAIL]
> [...]
>
> Tests passed: 36
> Tests failed: 4
> Tests skipped: 0
>
> Output with "nexthop: Forbid FDB status change while nexthop is in a
> group":
>
> # ./fib_nexthops.sh -t "ipv6_fdb_grp_fcnal ipv4_fdb_grp_fcnal"
>
> IPv6 fdb groups functional
> --------------------------
> [...]
> TEST: Replace FDB nexthop to non-FDB nexthop [ OK ]
> TEST: Replace non-FDB nexthop to FDB nexthop [ OK ]
> TEST: Replace FDB nexthop address while in a group [ OK ]
> TEST: Replace FDB nexthop to non-FDB nexthop while in a group [ OK ]
> TEST: Replace non-FDB nexthop to FDB nexthop while in a group [ OK ]
> [...]
>
> IPv4 fdb groups functional
> --------------------------
> [...]
> TEST: Replace FDB nexthop to non-FDB nexthop [ OK ]
> TEST: Replace non-FDB nexthop to FDB nexthop [ OK ]
> TEST: Replace FDB nexthop address while in a group [ OK ]
> TEST: Replace FDB nexthop to non-FDB nexthop while in a group [ OK ]
> TEST: Replace non-FDB nexthop to FDB nexthop while in a group [ OK ]
> [...]
>
> Tests passed: 40
> Tests failed: 0
> Tests skipped: 0
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> tools/testing/selftests/net/fib_nexthops.sh | 40 +++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2025-09-21 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 15:08 [PATCH net 0/3] nexthop: Various fixes Ido Schimmel
2025-09-21 15:08 ` [PATCH net 1/3] nexthop: Forbid FDB status change while nexthop is in a group Ido Schimmel
2025-09-21 15:35 ` David Ahern
2025-09-21 15:08 ` [PATCH net 2/3] selftests: fib_nexthops: Fix creation of non-FDB nexthops Ido Schimmel
2025-09-21 15:36 ` David Ahern
2025-09-21 15:08 ` [PATCH net 3/3] selftests: fib_nexthops: Add test cases for FDB status change Ido Schimmel
2025-09-21 15:39 ` David Ahern [this message]
2025-09-24 0:20 ` [PATCH net 0/3] nexthop: Various fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7b10e85-1201-4865-84c4-17e2d0971ac9@kernel.org \
--to=dsahern@kernel.org \
--cc=aroulin@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).