From: David Ahern <dsahern@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Andrea Claudi <aclaudi@redhat.com>
Cc: netdev@vger.kernel.org, Wen Liang <wenliang@redhat.com>,
David Ahern <dsahern@kernel.org>,
Victor Nogueira <victor@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Davide Caratti <dcaratti@redhat.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Vlad Buslov <vladbu@nvidia.com>
Subject: Re: [PATCH iproute2 v3 1/2] tc: u32: add support for json output
Date: Wed, 26 Jan 2022 08:50:39 -0700 [thread overview]
Message-ID: <a7ec49d5-8969-7999-43c4-12247decae9e@gmail.com> (raw)
In-Reply-To: <848d9baa-76d1-0a60-c9e4-7d59efbc5cbc@mojatatu.com>
On 1/26/22 6:52 AM, Jamal Hadi Salim wrote:
>
> Makes sense in particular if we have formal output format like json.
> If this breaks tdc it would be worth to fix tdc (and not be backward
> compatible)
>
> So: Since none of the tc maintainers was Cced in this thread, can we
> please impose a rule where any changes to tc subdir needs to have tdc
> tests run (and hopefully whoever is making the change will be gracious
> to contribute an additional testcase)?
I can try to remember to run tdc tests for tc patches. I looked into it
a few days ago and seems straightforward to run tdc.sh. The output of
those tests could be simplified - when all is good you get the one line
summary of the test name with PASS/FAIL with an option to run in verbose
mode to get the details of failures. As it is, the person running the
tests has to wade through a lot of output.
> Do you need a patch for that in some documentation?
>
How about adding some comments to README.devel?
next prev parent reply other threads:[~2022-01-26 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 18:45 [PATCH iproute2 v3 0/2] add json support on tc u32 Wen Liang
2022-01-06 18:45 ` [PATCH iproute2 v3 1/2] tc: u32: add support for json output Wen Liang
2022-01-06 22:30 ` Stephen Hemminger
2022-01-07 16:54 ` David Ahern
2022-01-24 18:25 ` Andrea Claudi
2022-01-24 18:50 ` Stephen Hemminger
2022-01-24 21:30 ` Andrea Claudi
2022-01-25 0:43 ` Stephen Hemminger
2022-01-26 13:52 ` Jamal Hadi Salim
2022-01-26 15:50 ` David Ahern [this message]
2022-01-31 12:54 ` Jamal Hadi Salim
2022-01-31 15:50 ` David Ahern
2022-01-31 19:37 ` Jamal Hadi Salim
2022-01-06 18:45 ` [PATCH iproute2 v3 2/2] tc: u32: add json support in `print_raw`, `print_ipv4`, `print_ipv6` Wen Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7ec49d5-8969-7999-43c4-12247decae9e@gmail.com \
--to=dsahern@gmail.com \
--cc=aclaudi@redhat.com \
--cc=dcaratti@redhat.com \
--cc=dsahern@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=victor@mojatatu.com \
--cc=vladbu@nvidia.com \
--cc=wenliang@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).