public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>, David Yang <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Simon Horman <horms@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next v4 1/3] dt-bindings: net: dsa: yt921x: Add Motorcomm YT921x switch support
Date: Tue, 19 Aug 2025 08:27:08 +0200	[thread overview]
Message-ID: <a7fc4e8d-453b-49c2-8177-20568431bf81@kernel.org> (raw)
In-Reply-To: <7c4bc4cc-61d5-40ce-b0d5-c47072ee2f16@lunn.ch>

On 18/08/2025 18:55, Andrew Lunn wrote:
>> +  motorcomm,switch-id:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: |
>> +      Value selected by Pin SWITCH_ID_1 / SWITCH_ID_0.
>> +
>> +      Up to 4 chips can share the same MII port ('reg' in DT) by giving
>> +      different SWITCH_ID values. The default value should work if only one chip
>> +      is present.
>> +    enum: [0, 1, 2, 3]
>> +    default: 0
> 
> It is like getting blood from a stone.
> 
> So what you are saying is that you have:
> 
>     mdio {
>         #address-cells = <1>;
>         #size-cells = <0>;
> 
>         switch@1d {
>             compatible = "motorcomm,yt9215";
>             /* default 0x1d, alternate 0x0 */
>             reg = <0x1d>;
>             motorcomm,switch-id = <0>;
>             reset-gpios = <&tlmm 39 GPIO_ACTIVE_LOW>;
> ...
> 	}
> 
>         switch@1d {
>             compatible = "motorcomm,yt9215";
>             reg = <0x1d>;
>             motorcomm,switch-id = <1>;
>             reset-gpios = <&tlmm 39 GPIO_ACTIVE_LOW>;
> ...
> 	}
> 
>         switch@1d {
>             compatible = "motorcomm,yt9215";
>             reg = <0x1d>;
>             motorcomm,switch-id = <2>;
>             reset-gpios = <&tlmm 39 GPIO_ACTIVE_LOW>;
> ...
> 	}
>     }
> 
> Have you tested this? My _guess_ is, it does not work.

Regardless if kernel actually works with this, but duplicating unit
address is not supported, so this obviously would be wrong. I guess
that's the answer for switch-id.

Best regards,
Krzysztof

  parent reply	other threads:[~2025-08-19  6:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 16:24 [net-next v4 0/3] net: dsa: yt921x: Add support for Motorcomm YT921x David Yang
2025-08-18 16:24 ` [net-next v4 1/3] dt-bindings: net: dsa: yt921x: Add Motorcomm YT921x switch support David Yang
2025-08-18 16:55   ` Andrew Lunn
2025-08-18 17:06     ` Yangfl
2025-08-18 17:16       ` Andrew Lunn
2025-08-19  6:27     ` Krzysztof Kozlowski [this message]
2025-08-18 16:24 ` [net-next v4 2/3] net: dsa: tag_yt921x: add support for Motorcomm YT921x tags David Yang
2025-08-18 17:07   ` Andrew Lunn
2025-08-18 17:32     ` Yangfl
2025-08-18 19:54       ` Andrew Lunn
2025-08-18 16:24 ` [net-next v4 3/3] net: dsa: yt921x: Add support for Motorcomm YT921x David Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7fc4e8d-453b-49c2-8177-20568431bf81@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mmyangfl@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox