From: Rao Shoaib <rao.shoaib@oracle.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
kuni1840@gmail.com, netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v2 net 2/2] af_unix: Don't peek OOB data without MSG_OOB.
Date: Tue, 16 Apr 2024 14:34:20 -0700 [thread overview]
Message-ID: <a7fe079c-5ed7-4ff6-a127-adb34b2246f5@oracle.com> (raw)
In-Reply-To: <20240416205125.13919-1-kuniyu@amazon.com>
On 4/16/24 13:51, Kuniyuki Iwashima wrote:
> From: Rao Shoaib <rao.shoaib@oracle.com>
> Date: Tue, 16 Apr 2024 13:11:09 -0700
>> The proposed fix is not the correct fix as among other things it does
>> not allow going pass the OOB if data is present. TCP allows that.
>
> Ugh, exactly.
>
> But the behaviour was broken initially, so the tag is
>
> Fixes: 314001f0bf92 ("af_unix: Add OOB support")
>
Where is this requirement listed?
> Could you post patches formally on top of the latest net.git ?
> It seems one of my patch is squashed.
I pulled in last night, your last fix has not yet made it (I think)
[rshoaib@turbo-2 linux_oob]$ git describe
v6.9-rc4-32-gbf541423b785
>
> Also, please note that one patch should fix one issue.
> The change in queue_oob() should be another patch.
>
I was just responding to your email. I was not sure if you wanted to
modify your fix. If you prefer I submit the patches, I will later.
Shoaib
next prev parent reply other threads:[~2024-04-16 21:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 17:10 [PATCH v2 net 0/2] af_unix: Fix MSG_OOB bugs with MSG_PEEK Kuniyuki Iwashima
2024-04-10 17:10 ` [PATCH v2 net 1/2] af_unix: Call manage_oob() for every skb in unix_stream_read_generic() Kuniyuki Iwashima
2024-04-15 2:26 ` Rao Shoaib
2024-04-10 17:10 ` [PATCH v2 net 2/2] af_unix: Don't peek OOB data without MSG_OOB Kuniyuki Iwashima
2024-04-16 20:11 ` Rao Shoaib
2024-04-16 20:51 ` Kuniyuki Iwashima
2024-04-16 21:34 ` Rao Shoaib [this message]
2024-04-16 21:47 ` Kuniyuki Iwashima
2024-04-16 22:01 ` Rao Shoaib
2024-04-16 22:10 ` Kuniyuki Iwashima
2024-04-17 4:37 ` Rao Shoaib
2024-04-13 2:10 ` [PATCH v2 net 0/2] af_unix: Fix MSG_OOB bugs with MSG_PEEK patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7fe079c-5ed7-4ff6-a127-adb34b2246f5@oracle.com \
--to=rao.shoaib@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).