From: Richard Gobert <richardbgobert@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, corbet@lwn.net,
shenjian15@huawei.com, salil.mehta@huawei.com,
shaojijie@huawei.com, andrew+netdev@lunn.ch, saeedm@nvidia.com,
tariqt@nvidia.com, mbloch@nvidia.com, leon@kernel.org,
ecree.xilinx@gmail.com, dsahern@kernel.org, ncardwell@google.com,
kuniyu@google.com, shuah@kernel.org, sdf@fomichev.me,
ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
linux-kernel@vger.kernel.org, linux-net-drivers@amd.com
Subject: Re: [PATCH net-next 5/5] selftests/net: test ipip packets in gro.sh
Date: Mon, 18 Aug 2025 14:06:02 +0200 [thread overview]
Message-ID: <a803b83d-26f3-4127-8502-64b2b4eac3a5@gmail.com> (raw)
In-Reply-To: <20250814124209.699478a5@kernel.org>
Jakub Kicinski wrote:
> On Thu, 14 Aug 2025 13:40:30 +0200 Richard Gobert wrote:
>> Add IPIP test-cases to the GRO selftest.
>>
>> This selftest already contains IP ID test-cases. They are now
>> also tested for encapsulated packets.
>
> The series seems to break the test when running in our CI:
>
> https://netdev-3.bots.linux.dev/vmksft-net/results/253062/25-gro-sh/stdout
> https://netdev-3.bots.linux.dev/vmksft-net/results/253062/25-gro-sh-retry/stdout
>
> https://netdev-3.bots.linux.dev/vmksft-net/results/253241/18-gro-sh/stdout
> https://netdev-3.bots.linux.dev/vmksft-net/results/253241/18-gro-sh-retry/stdout
Missed this. Turns out the test does not generate
IPIP packets correctly in some cases. Will fix in v2.
prev parent reply other threads:[~2025-08-18 12:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 11:40 [PATCH net-next 0/5] net: gso: restore outer ip ids correctly Richard Gobert
2025-08-14 11:40 ` [PATCH net-next 1/5] net: gro: remove is_ipv6 from napi_gro_cb Richard Gobert
2025-08-14 20:45 ` Florian Fainelli
2025-08-15 10:17 ` Willem de Bruijn
2025-08-18 11:33 ` Richard Gobert
2025-08-14 11:40 ` [PATCH net-next 2/5] net: gro: only merge packets with incrementing or fixed outer ids Richard Gobert
2025-08-14 11:40 ` [PATCH net-next 3/5] net: gso: restore ids of outer ip headers correctly Richard Gobert
2025-08-15 10:23 ` Willem de Bruijn
2025-08-15 13:00 ` Willem de Bruijn
2025-08-18 11:46 ` Richard Gobert
2025-08-18 11:58 ` Willem de Bruijn
2025-08-18 14:07 ` Richard Gobert
2025-08-14 11:40 ` [PATCH net-next 4/5] net: gro: remove unnecessary df checks Richard Gobert
2025-08-14 11:40 ` [PATCH net-next 5/5] selftests/net: test ipip packets in gro.sh Richard Gobert
2025-08-14 19:42 ` Jakub Kicinski
2025-08-18 12:06 ` Richard Gobert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a803b83d-26f3-4127-8502-64b2b4eac3a5@gmail.com \
--to=richardbgobert@gmail.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=mbloch@nvidia.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=sdf@fomichev.me \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).