From: Shoaib Rao <rao.shoaib@oracle.com>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev <netdev@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] af_unix: fix holding spinlock in oob handling
Date: Thu, 12 Aug 2021 10:37:49 -0700 [thread overview]
Message-ID: <a807dd9c-4f8a-c205-8fa0-01effdd54553@oracle.com> (raw)
In-Reply-To: <CANn89i+utnHk-aoS=q2sLC8uLaMJDYsW=1O+c4fzODQd0P3stA@mail.gmail.com>
On 8/12/21 12:53 AM, Eric Dumazet wrote:
> if (ousk->oob_skb)
> - kfree_skb(ousk->oob_skb);
> + consume_skb(ousk->oob_skb);
Should I be using consume_skb(), as the skb is not being consumed, the
ref count is decremented and if zero skb will be freed.
Shoaib
next prev parent reply other threads:[~2021-08-12 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 22:06 [PATCH] af_unix: fix holding spinlock in oob handling Rao Shoaib
2021-08-12 7:53 ` Eric Dumazet
2021-08-12 16:23 ` Shoaib Rao
2021-08-12 17:37 ` Shoaib Rao [this message]
2021-08-12 20:33 ` Eric Dumazet
2021-08-12 20:38 ` Shoaib Rao
2021-08-13 17:32 ` Jakub Kicinski
2021-08-13 17:59 ` Shoaib Rao
-- strict thread matches above, loose matches on Subject: below --
2021-08-13 17:46 Rao Shoaib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a807dd9c-4f8a-c205-8fa0-01effdd54553@oracle.com \
--to=rao.shoaib@oracle.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).