From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F38EC433EF for ; Mon, 11 Apr 2022 09:07:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344119AbiDKJJc (ORCPT ); Mon, 11 Apr 2022 05:09:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231960AbiDKJJb (ORCPT ); Mon, 11 Apr 2022 05:09:31 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3558B205DD for ; Mon, 11 Apr 2022 02:07:17 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id u18so6824583eda.3 for ; Mon, 11 Apr 2022 02:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Urg3WNbWAAbmT/1unZ8S+i2ajaf9UWWtyCFD6wiRjuI=; b=ibyW2IIHcc8wVZkOHS/s3WSv0MoDzWtmuPnwfhxKEi4RzBk+lE+OjaZj1DhEPuw3Hy 6NJ+CVirQCZZcErNoU0TAeox7TvSA/CXrx4gFqLwyEAmtLusg2Gr1PN5ur2YAPvxGmMx l1llRE5cg55Kho7+i0Suwu/IgcZ5k6U+blXsx/wc1j5CokN/Ry6tC01zoSbllzYJNACg XPkLEi65esJc8k4lnuPC40ZEp1Od8Y5LSzhcmhOtqZMMvnDrZTcodeFp2SWWjdlOUNsK 8FLIvFyFV/lB5HpY7PItzvZJ8xADMKRWwUY9xYisLDX7x052HHECkMO+7GDDEzpz1jbu 7syw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Urg3WNbWAAbmT/1unZ8S+i2ajaf9UWWtyCFD6wiRjuI=; b=6cJncOhirCXPY9Og0oDdgC/TCPF+8ohFgeM2jUdYXQQqxBdhcgXeHzvELrYf0M4CeJ u2ZHEzxswzTqEUib+yqLkjCBTdxVw2ZhafmyIjmoekf61shdYpq8nmZWH+/RJRygp23z R9HbGPrsNGsPhn1wlf3C//EsNVZKGKFQT4aMyGWc7GHEorT59RGHAdlyAJEjWIGYfM56 lHYpl6jY+1X2vAwe9srJYsYluGGORQTg9x6TesPEqjzAux/HcQWm3KUQwVO02oNdgaOt k0mXQB7Cy1CTbFQVhJMrLCpUZxpbWVSoDbWtH8FOox2gIOV4GjQsSc6q6J5zwyl4RA+i jyig== X-Gm-Message-State: AOAM532pbg6/7jwO63AVbpK2DxxuMF31hodm1xPepc/F0Wo3LS9le8fz y0XHJaJ5frkQRE1UDP4VOk/Tyw== X-Google-Smtp-Source: ABdhPJzhJalaqUptPqm4oxnVKC+KyE7L+rULrYE4tCHqDaE2vTvvQb6dq2zbbq1HN4y7QNIjT/3USw== X-Received: by 2002:a05:6402:26c8:b0:419:2e54:9262 with SMTP id x8-20020a05640226c800b004192e549262mr31862541edd.61.1649668035740; Mon, 11 Apr 2022 02:07:15 -0700 (PDT) Received: from [192.168.0.111] (87-243-81-1.ip.btc-net.bg. [87.243.81.1]) by smtp.gmail.com with ESMTPSA id w14-20020a509d8e000000b0041cd217726dsm11336827ede.4.2022.04.11.02.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 02:07:15 -0700 (PDT) Message-ID: Date: Mon, 11 Apr 2022 12:07:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH net-next 4/6] net: bridge: fdb: add support for flush filtering based on ndm flags and state Content-Language: en-US To: Ido Schimmel Cc: netdev@vger.kernel.org, roopa@nvidia.com, kuba@kernel.org, davem@davemloft.net, bridge@lists.linux-foundation.org References: <20220409105857.803667-1-razor@blackwall.org> <20220409105857.803667-5-razor@blackwall.org> From: Nikolay Aleksandrov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/04/2022 11:47, Ido Schimmel wrote: > On Sat, Apr 09, 2022 at 01:58:55PM +0300, Nikolay Aleksandrov wrote: >> Add support for fdb flush filtering based on ndm flags and state. The >> new attributes allow users to specify a mask and value which are mapped >> to bridge-specific flags. NTF_USE is used to represent added_by_user >> flag since it sets it on fdb add and we don't have a 1:1 mapping for it. >> >> Signed-off-by: Nikolay Aleksandrov >> --- >> include/uapi/linux/if_bridge.h | 4 +++ >> net/bridge/br_fdb.c | 55 ++++++++++++++++++++++++++++++++++ >> 2 files changed, 59 insertions(+) >> >> diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h >> index 2f3799cf14b2..4638d7e39f2a 100644 >> --- a/include/uapi/linux/if_bridge.h >> +++ b/include/uapi/linux/if_bridge.h >> @@ -815,6 +815,10 @@ enum { >> /* embedded in BRIDGE_FLUSH_FDB */ >> enum { >> FDB_FLUSH_UNSPEC, >> + FDB_FLUSH_NDM_STATE, >> + FDB_FLUSH_NDM_STATE_MASK, >> + FDB_FLUSH_NDM_FLAGS, >> + FDB_FLUSH_NDM_FLAGS_MASK, >> __FDB_FLUSH_MAX >> }; >> #define FDB_FLUSH_MAX (__FDB_FLUSH_MAX - 1) >> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c >> index 62f694a739e1..340a2ace1d5e 100644 >> --- a/net/bridge/br_fdb.c >> +++ b/net/bridge/br_fdb.c >> @@ -594,8 +594,40 @@ void br_fdb_flush(struct net_bridge *br, >> rcu_read_unlock(); >> } >> >> +static unsigned long __ndm_state_to_fdb_flags(u16 ndm_state) >> +{ >> + unsigned long flags = 0; >> + >> + if (ndm_state & NUD_PERMANENT) >> + __set_bit(BR_FDB_LOCAL, &flags); >> + if (ndm_state & NUD_NOARP) >> + __set_bit(BR_FDB_STATIC, &flags); >> + >> + return flags; >> +} >> + >> +static unsigned long __ndm_flags_to_fdb_flags(u16 ndm_flags) >> +{ >> + unsigned long flags = 0; >> + >> + if (ndm_flags & NTF_USE) >> + __set_bit(BR_FDB_ADDED_BY_USER, &flags); >> + if (ndm_flags & NTF_EXT_LEARNED) >> + __set_bit(BR_FDB_ADDED_BY_EXT_LEARN, &flags); >> + if (ndm_flags & NTF_OFFLOADED) >> + __set_bit(BR_FDB_OFFLOADED, &flags); >> + if (ndm_flags & NTF_STICKY) >> + __set_bit(BR_FDB_STICKY, &flags); >> + >> + return flags; >> +} >> + >> static const struct nla_policy br_fdb_flush_policy[FDB_FLUSH_MAX + 1] = { >> [FDB_FLUSH_UNSPEC] = { .type = NLA_REJECT }, >> + [FDB_FLUSH_NDM_STATE] = { .type = NLA_U16 }, >> + [FDB_FLUSH_NDM_FLAGS] = { .type = NLA_U16 }, >> + [FDB_FLUSH_NDM_STATE_MASK] = { .type = NLA_U16 }, >> + [FDB_FLUSH_NDM_FLAGS_MASK] = { .type = NLA_U16 }, > > Might be better to use NLA_POLICY_MASK(NLA_U16, mask) and reject > unsupported states / flags instead of just ignoring them? > Yep, forgot about that one. Good point!