From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B82FC43381 for ; Tue, 26 Mar 2019 14:54:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C4BE2075E for ; Tue, 26 Mar 2019 14:54:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="irBiFrLH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731491AbfCZOys (ORCPT ); Tue, 26 Mar 2019 10:54:48 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36677 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbfCZOys (ORCPT ); Tue, 26 Mar 2019 10:54:48 -0400 Received: by mail-wr1-f67.google.com with SMTP id y13so14755043wrd.3 for ; Tue, 26 Mar 2019 07:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5OMgMznDF2EsBC2vag8dfpyj+EliveC2Ol90RAz20Qw=; b=irBiFrLH4zRkkiKIbdswjk7pW4ar7g2pNttPqK7J/DFKlo5VjAjnS1XF3+okjwhn/h F2LecwB6mtZYvpmXGFOsSXXNmGbHtvODpKAnZkzw0ATlIPxVpQ6km0HrcG3Z1XB8dJgW 44hYFdBFNvC17DibF7ElfAUMfMYIxg3GAHCpXMN9pyOITnps2ykrJSQAgddMD++FPwTL b2LGMSPe+KkNb86vfZYFQU2Wka/HJepk5ZhX7Gq1zCZ7QYTn6nVpjjFdonx9ZjE+9lxE wqW+K+gJwRmVbJSTv7KFuylnS/8gDVh3ZVAR2RU8bL5Zlx+cXYILLi07NSbQefc/l+2C piQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5OMgMznDF2EsBC2vag8dfpyj+EliveC2Ol90RAz20Qw=; b=gfFNK9J7FmU1ztvEV4/qghf8JUxDvN3IaQo8iRb4W+OFaET20+JQzAYE3xyAfG/QuP lqg7STxE3CFIGuNuKV0RIe6bVV4CJMk45cvyYGreadGRLT6Y74EbtB1Xkh4rgf28fI1Z Bvuus3di5zjWW9UqOpoMsD9LLK1tMiaB8DTQy/5AahrbSvrMmFUUIX7spJ7kyMx3PFv7 r5SHN2YS1Mxk6974Y8ZnEEknU4Awr2/zoly7Z2JPUfjfZMUsFCDf3YF7EvlxRqIRAYPi ZvLkpu4SltDzrZ0yGRhi9L5i8gQi7407XcXyW9duI4dHY9gdlGVhOn9NbwSb82IvIEbD ZkjA== X-Gm-Message-State: APjAAAWrYwLkCIZ9OriBaRz3NWFzNsehPtyciR8M1/iFDBzPOsrqlM9Y kBbWmRfMzS09Da+otZNfnxc= X-Google-Smtp-Source: APXvYqwqj6N4bBUef5q5bEjfQFzFZZF9nzEWKKQj5RDlqItdYepK6uMSPAhbZItilUhjhYOr7xtgyg== X-Received: by 2002:a5d:5284:: with SMTP id c4mr5773856wrv.281.1553612086930; Tue, 26 Mar 2019 07:54:46 -0700 (PDT) Received: from [192.168.8.147] (26.249.23.93.rev.sfr.net. [93.23.249.26]) by smtp.gmail.com with ESMTPSA id p3sm11977367wrx.71.2019.03.26.07.54.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 07:54:46 -0700 (PDT) Subject: Re: [PATCH net-next] dpaa2-eth: use netif_receive_skb_list To: Jesper Dangaard Brouer , Ioana Ciornei Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , Ioana Ciocoi Radulescu , Florian Westphal , Edward Cree References: <1553521344-31094-1-git-send-email-ioana.ciornei@nxp.com> <20190326154315.7476de9d@carbon> From: Eric Dumazet Message-ID: Date: Tue, 26 Mar 2019 07:54:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190326154315.7476de9d@carbon> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/26/2019 07:43 AM, Jesper Dangaard Brouer wrote: > On Mon, 25 Mar 2019 13:42:39 +0000 > Ioana Ciornei wrote: > >> Take advantage of the software Rx batching by using >> netif_receive_skb_list instead of napi_gro_receive. >> >> Signed-off-by: Ioana Ciornei >> --- > > Nice to see more people/drivers using: netif_receive_skb_list() > > We should likely add a similar napi_gro_receive_list() function. GRO is essentially processing one frame at a time, and recycling one sk_buff. (one sk_buff per aggregated train) Having to allocate one sk_buff per MSS just to provide a list would likely be slower, as far as GRO is concerned.