From: Andrew Lunn <andrew@lunn.ch>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Wen Gu <guwen@linux.alibaba.com>,
Philo Lu <lulie@linux.alibaba.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Lukas Bulwahn <lukas.bulwahn@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Vivian Wang <wangruikang@iscas.ac.cn>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Dust Li <dust.li@linux.alibaba.com>,
alok.a.tiwari@oracle.com, kalesh-anakkur.purayil@broadcom.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v5] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor
Date: Tue, 14 Oct 2025 14:43:01 +0200 [thread overview]
Message-ID: <a8936e7e-da32-4562-a88e-af5d763a883e@lunn.ch> (raw)
In-Reply-To: <1760441688.9352384-1-xuanzhuo@linux.alibaba.com>
> > That also means that you require the reviewers to invest a lot of extra
> > effort here, which in turn does not help making progresses.
>
> Indeed, it's been quite a while, but I haven't made any substantial progress on
> this patchset, and I'm really considering this. Would splitting up a few commits
> speed up the review process?
Flip the question around, say you where asked to review this work
mixed in with all your other work. Would you not find it easier to
review 15 small patches, one per coffee break, after lunch, before
setting off home, waiting for a kernel to compile, etc, than one huge
patch.
Also, good subject lines attacks reviews who have interests in
subsections. If the subject line says ethtool, i'm more likely to look
at that one patch, and you will get a review of it. When ethtool is
not obvious, i probably won't bother.
Andrew
next prev parent reply other threads:[~2025-10-14 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 2:18 [PATCH net-next v5] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor Xuan Zhuo
2025-10-14 11:25 ` Paolo Abeni
2025-10-14 11:34 ` Xuan Zhuo
2025-10-14 12:43 ` Andrew Lunn [this message]
2025-10-14 12:19 ` Jiri Pirko
2025-10-15 0:57 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8936e7e-da32-4562-a88e-af5d763a883e@lunn.ch \
--to=andrew@lunn.ch \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=guwen@linux.alibaba.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=lulie@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=troy.mitchell@linux.spacemit.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wangruikang@iscas.ac.cn \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox