From: Roi Dayan <roid@nvidia.com>
To: David Ahern <dsahern@gmail.com>, <netdev@vger.kernel.org>
Cc: Paul Blakey <paulb@nvidia.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next v3 1/1] police: Add support for json output
Date: Mon, 7 Jun 2021 09:16:57 +0300 [thread overview]
Message-ID: <a8ac760c-e05e-e01c-4c84-5883370ba403@nvidia.com> (raw)
In-Reply-To: <4926d9e1-4b0a-75b8-6a63-c1fd67eff58a@gmail.com>
On 2021-06-07 5:48 AM, David Ahern wrote:
> On 6/6/21 12:22 AM, Roi Dayan wrote:
>> diff --git a/tc/m_police.c b/tc/m_police.c
>> index 9ef0e40b861b..560a793245c8 100644
>> --- a/tc/m_police.c
>> +++ b/tc/m_police.c
>> @@ -278,18 +278,19 @@ static int print_police(struct action_util *a, FILE *f, struct rtattr *arg)
>> __u64 rate64, prate64;
>> __u64 pps64, ppsburst64;
>>
>> + print_string(PRINT_ANY, "kind", "%s", "police");
>> if (arg == NULL)
>> return 0;
>>
>> parse_rtattr_nested(tb, TCA_POLICE_MAX, arg);
>>
>> - if (tb[TCA_POLICE_TBF] == NULL) {
>> - fprintf(f, "[NULL police tbf]");
>> - return 0;
>> + if (tb[TCA_POLICE_TBF] == NULL || true) {
>
> why '|| true'? leftover from special casing tests?
>
>
>
oops debug left over. sorry for that. fixing.
prev parent reply other threads:[~2021-06-07 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 6:22 [PATCH iproute2-next v3 1/1] police: Add support for json output Roi Dayan
2021-06-07 2:48 ` David Ahern
2021-06-07 6:16 ` Roi Dayan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8ac760c-e05e-e01c-4c84-5883370ba403@nvidia.com \
--to=roid@nvidia.com \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=paulb@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).