From: Jeremy Kerr <jk@codeconstruct.com.au>
To: ALOK TIWARI <alok.a.tiwari@oracle.com>,
matt@codeconstruct.com.au, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org
Subject: Re: [QUERY] mctp: getsockopt unknown option return code -EINVAL
Date: Tue, 02 Sep 2025 11:59:02 +0800 [thread overview]
Message-ID: <a8c2dd5d8f72820941a3f4d660db3076ff9a8b52.camel@codeconstruct.com.au> (raw)
In-Reply-To: <f5978c86-5271-4699-bb7d-92e3f2e2b9be@oracle.com>
Hi Alok,
> I was not looking at a specific path, I just noticed the
> inconsistency in the return codes between getsockopt and setsockopt.
>
> Extending this to the level != SOL_MCTP case would also require
> changes in the mctp_setsockopt() API.
Yep. The changes to the level error path may have different semantics,
so if you'd prefer to look at that separately, that's fine.
> Also, would it be fine if I send this patch to [net-next] without a
> Fixes tag?
All fine by me.
We're fairly safe from any side-effects here, as we only have the one
sockopt, but we do want to ensure that remains the case in future,
particularly if any new sockopts are introduced.
Cheers,
Jeremy
prev parent reply other threads:[~2025-09-02 3:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 7:11 [QUERY] mctp: getsockopt unknown option return code -EINVAL Alok Tiwari
2025-09-01 7:24 ` Jeremy Kerr
2025-09-01 9:59 ` ALOK TIWARI
2025-09-02 3:59 ` Jeremy Kerr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8c2dd5d8f72820941a3f4d660db3076ff9a8b52.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=alok.a.tiwari@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).