From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE9CC282C4 for ; Tue, 12 Feb 2019 09:01:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C0F92080A for ; Tue, 12 Feb 2019 09:01:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="rGPUQh1O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728581AbfBLJBY (ORCPT ); Tue, 12 Feb 2019 04:01:24 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:34458 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728086AbfBLJBY (ORCPT ); Tue, 12 Feb 2019 04:01:24 -0500 Received: by mail-lj1-f195.google.com with SMTP id v14-v6so1554762ljv.1 for ; Tue, 12 Feb 2019 01:01:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=ArrNps3uN+qLBvjvmmUb5d83hC25sB9QxDwggFZUpW0=; b=rGPUQh1OaAou0+VMCWn3YvnRrZ8E5jrhHycb8vmooJYOXV6ngFxZmlHuD3i1cmhpEQ fqz39YfpiZVbupVJ48umr6lhKecEgYiWB9uW1ZvYjzocSyrgF1ZDqTMPZtlN4IYCBInC 5YR2fV9oYjKnCjrKuFVwMZUsz1Q68QpsAkAT647dACyj1M2VcWu8L7g+E4ahS5C6YvCL gaB5pnxMWJ7oqRBzWZmsG6QRxNBQnrOlmd1fYnsL453+b4bubv857YQDzvzT8UdWbR1E Zqle6n32fSxYC79mDiGd8tS/guBkscrX5MJ05BGXeeTfVbO+N1MaPwDhXC4K9cmZtJSC C5Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ArrNps3uN+qLBvjvmmUb5d83hC25sB9QxDwggFZUpW0=; b=rJtTPfd1y+AMH0gJdpk11fAozlRbXPbh6PXUrcs0CBzBM94HbRBPKuEsmiqDSTZ1pb GtVY99ZUtbOl+V4F7vcSIExwQxeIiDu5C/Cp3tsrxpgcJy6y1tiUmpYr9q9bHGqBXK/P 2lgabucUQrwD64eyUgNX5SwQ5JhSbZp9+qmylvaGi5VVJmlVv5i+C6lvvEjrSQKBCq4k 5iuO8OJpXh3vJznlod3cClTWLwswlH+qd1y/KozB7i73GMp0CIFMRrY3EHpJaBUMunY9 BwpZ9nqyMoD6Aw42pSKsh24wgtk4Z+2kYjuXzhF8mBEKFSQwmUOQJOjWCBz69vnf3hMJ 17EQ== X-Gm-Message-State: AHQUAuYFLre7WV2omXbr9NhGVfRJ0JvmU1J0/938QW1xWfvu6TiUyRgW yV7vjDY7C6tXOnfM0coZhG0p9xHVgH0= X-Google-Smtp-Source: AHgI3IZUntc5s+lIqcnLQvB0dMoSoS7KlUzgT8RIfiePuWZmtFLMO4b+K9VWkTVHcNbTVAd4t6bROA== X-Received: by 2002:a2e:7e11:: with SMTP id z17-v6mr1620518ljc.106.1549962081755; Tue, 12 Feb 2019 01:01:21 -0800 (PST) Received: from [192.168.0.199] ([31.173.84.178]) by smtp.gmail.com with ESMTPSA id i21sm855813lfj.60.2019.02.12.01.01.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 01:01:20 -0800 (PST) Subject: Re: [PATCH net-next 2/2] devlink: Fix list access without lock while reading region To: Parav Pandit , jiri@mellanox.com, davem@davemloft.net, netdev@vger.kernel.org References: <1549955377-15828-1-git-send-email-parav@mellanox.com> From: Sergei Shtylyov Message-ID: Date: Tue, 12 Feb 2019 12:01:13 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <1549955377-15828-1-git-send-email-parav@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! On 12.02.2019 10:09, Parav Pandit wrote: > While finding the devlink device during region reading, > devlink device list is accessed and devlink device is > returned without holding a lock. This could lead to user-after-free Use-after-free, perhaps? > accesses. > > While at it, add lockdep assert to ensure that all future callers hold > the lock when calling devlink_get_from_attrs(). > > Fixes: 4e54795a27f5 ("devlink: Add support for region snapshot read command") > Signed-off-by: Parav Pandit > Acked-by: Jiri Pirko [...] MBR, Sergei