netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status
Date: Sat, 2 Mar 2019 17:15:56 +0100	[thread overview]
Message-ID: <a8fc4b70-1861-c8ca-c62e-941ce5baa39e@gmail.com> (raw)
In-Reply-To: <7c0ef5fe-2f4f-d365-a028-d96179e9fab4@gmail.com>

gen10g_read_status is deprecated, therefore stop exporting it.
We don't want to encourage anybody to use it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/phy-c45.c | 3 +--
 include/linux/phy.h       | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
index cdbcea860..6cd4bd5e9 100644
--- a/drivers/net/phy/phy-c45.c
+++ b/drivers/net/phy/phy-c45.c
@@ -499,7 +499,7 @@ int gen10g_config_aneg(struct phy_device *phydev)
 }
 EXPORT_SYMBOL_GPL(gen10g_config_aneg);
 
-int gen10g_read_status(struct phy_device *phydev)
+static int gen10g_read_status(struct phy_device *phydev)
 {
 	/* For now just lie and say it's 10G all the time */
 	phydev->speed = SPEED_10000;
@@ -507,7 +507,6 @@ int gen10g_read_status(struct phy_device *phydev)
 
 	return genphy_c45_read_link(phydev);
 }
-EXPORT_SYMBOL_GPL(gen10g_read_status);
 
 int gen10g_no_soft_reset(struct phy_device *phydev)
 {
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 817c8453a..607942401 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -1119,7 +1119,6 @@ int genphy_c45_read_status(struct phy_device *phydev);
 
 /* The gen10g_* functions are the old Clause 45 stub */
 int gen10g_config_aneg(struct phy_device *phydev);
-int gen10g_read_status(struct phy_device *phydev);
 int gen10g_no_soft_reset(struct phy_device *phydev);
 
 static inline int phy_read_status(struct phy_device *phydev)
-- 
2.21.0



  parent reply	other threads:[~2019-03-02 16:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-02 16:09 [PATCH net-next 0/5] net: phy: clean up the old gen10g functions Heiner Kallweit
2019-03-02 16:10 ` [PATCH net-next 1/5] net: phy: use genphy_c45_aneg_done in genphy_aneg_done Heiner Kallweit
2019-03-03 15:34   ` Andrew Lunn
2019-03-02 16:10 ` [PATCH net-next 2/5] net: phy: remove gen10g_suspend and gen10g_resume Heiner Kallweit
2019-03-03 15:37   ` Andrew Lunn
2019-03-02 16:11 ` [PATCH net-next 3/5] net: phy: remove gen10g_config_init Heiner Kallweit
2019-03-03 15:39   ` Andrew Lunn
2019-03-02 16:13 ` [PATCH net-next 5/5] net: phy: remove gen10g_no_soft_reset Heiner Kallweit
2019-03-03 15:45   ` Andrew Lunn
2019-03-02 16:15 ` Heiner Kallweit [this message]
2019-03-03 15:48   ` [PATCH net-next 4/5] net: phy: don't export gen10g_read_status Andrew Lunn
2019-03-03 15:58   ` Andrew Lunn
2019-03-03 16:12     ` Heiner Kallweit
2019-03-04 15:26       ` Jose Abreu
2019-03-04 15:52         ` Andrew Lunn
2019-03-04  5:48 ` [PATCH net-next 0/5] net: phy: clean up the old gen10g functions David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8fc4b70-1861-c8ca-c62e-941ce5baa39e@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).