public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: psr <pradeep.rautela@gmail.com>
To: "Shani Moideen" <shani.moideen@wipro.com>
Cc: jgarzik@pobox.com, akpm@linux-foundation.org,
	netdev@vger.kernel.org, kernel-janitors@lists.osdl.org
Subject: Re: [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp) in net/core/pktgen.c
Date: Wed, 13 Jun 2007 15:42:39 +0530	[thread overview]
Message-ID: <a901b49a0706130312mba8a686m455b5cbf774cc159@mail.gmail.com> (raw)
In-Reply-To: <1181702562.2282.12.camel@shani-win>

On 6/13/07, Shani Moideen <shani.moideen@wipro.com> wrote:
>
> Replacing alloc_pages(gfp,0) with alloc_page(gfp)
> in net/core/pktgen.c
>
> Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> ----
>
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index b92a322..2600c7f 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -2414,7 +2414,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
>
>                 i = 0;
>                 while (datalen > 0) {
> -                       struct page *page = alloc_pages(GFP_KERNEL, 0);
> +                       struct page *page = alloc_page(GFP_KERNEL);

Does this makes any difference anyway? Both are same eventually?
What is the rational behind this? Can you please help me understanding this?

thanks
--pradeep
>                         skb_shinfo(skb)->frags[i].page = page;
>                         skb_shinfo(skb)->frags[i].page_offset = 0;
>                         skb_shinfo(skb)->frags[i].size =
> @@ -2762,7 +2762,7 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,
>
>                 i = 0;
>                 while (datalen > 0) {
> -                       struct page *page = alloc_pages(GFP_KERNEL, 0);
> +                       struct page *page = alloc_page(GFP_KERNEL);
>                         skb_shinfo(skb)->frags[i].page = page;
>                         skb_shinfo(skb)->frags[i].page_offset = 0;
>                         skb_shinfo(skb)->frags[i].size =
>
> --
> Shani
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
>

  reply	other threads:[~2007-06-13 10:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13  2:42 [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/core/pktgen.c Shani Moideen
2007-06-13 10:12 ` psr [this message]
2007-06-13 13:14   ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) " Robert P. J. Day
2007-06-13 14:28     ` psr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a901b49a0706130312mba8a686m455b5cbf774cc159@mail.gmail.com \
    --to=pradeep.rautela@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jgarzik@pobox.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=netdev@vger.kernel.org \
    --cc=shani.moideen@wipro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox