From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6207155359 for ; Wed, 25 Sep 2024 07:15:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727248522; cv=none; b=mk3pdWcOBxhBjMPiWN+YpnLJG4P4HcE9His12iTZ9Jx5cdjMsnJX5fIGZOzUNS6cEs7T2Zs7N/K5V07cSfcjXNnZJ6i4le4NwAL0Zn1G7r7P6c4BW6wf93hGPB19tPoZq+7Tz8MFFkpNnKwjZQ1Vv2XDRRbYfqkqhJSqdbi+aoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727248522; c=relaxed/simple; bh=bzDm4Enp3hXtpfidzf2ceHBrZX4lL5SUOpIuF63CRsU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZPWeqcUhgxfXDEi1dEkbm/9nOqNLmYg4xOwlqITx4P8tSUt5G6FuhxPzxoNckrhSHZo0kclc1zhBMJvLGnD9RYE6UeCMLPmE3/TxudzTXoa90PTl0p6oU0QQEExG7OxHzpNab0n8grNwgIn7oVJdD7YDx4XpgTQe51bv0DAKc7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Pga7sfP9; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Pga7sfP9" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-378e5d4a80eso4738122f8f.0 for ; Wed, 25 Sep 2024 00:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727248519; x=1727853319; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CMsn/bPHV7l0Tw2fIB2aHezcx6bxNnjGnFjV9MafOuk=; b=Pga7sfP9lc06KLzb19mzsp4vCaXNxMx/B9xE9caNSqdOntaDCpSAzZTIpTOgufIXEG 9oNeHKUMZyQ0agR+t+/h3s9Qo1JQVfpEF4f6Qt5DlbvcwkLQIyhw7Cm01YLl8NyrifsY OgqrT7O2wmKB2pr2tLCaiRf6mOy4WRVYS2OjqoRQ2CVhX66hTnUFUTjjMF2qVL8v8tb0 JZ3R9yhazMP7j5X3MvfU+C5UyVj2HwcVI0wBtN1cbkOtUhUuQQIRuQxgUnEOG1jQAZL/ f4i2yZ2yPpglvlYZcmtamL8W+nAVv2OqydX+XyudFPag0aRYOPlRdQ1WedsOQDnsbUCl 8jUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727248519; x=1727853319; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CMsn/bPHV7l0Tw2fIB2aHezcx6bxNnjGnFjV9MafOuk=; b=j2Ix9UAA4hEAWMePyJovQFkzJGS0QUuvTySAW4iVJqpCoZ+weSy313Tz/v32DeOyeu Uf9HaAs6u79PVZiQ9woB7ZgnFcfAgIt4MLR63cboLi06nTHoopkTpaGnnp8kDgA3TD8f FMomFSWGh/t+gXFVMEYwKpUnWRVRd2J3rcPsRU4Tcn3PIubphnAnqaESTijS5SIPSUPQ R8Nd4w0gnr27IaWQfI//+1Ag/rw7JO0v9CF3YgOg/rukee5BUT7z7DNs/+10SgGma2tS PWIFhmA1C3TUR5hA15AEKqmZyr6YtKr/CvQzMh4WANgJOOAqr5XdDd/HhzMu3BYaQNqj vN7g== X-Forwarded-Encrypted: i=1; AJvYcCW+/g6py62FaABqlg+PibmfbR6byDC0LPgsBh10Tl6NG69zQPZHqr4WUpbqECwYmRmH9w/e85g=@vger.kernel.org X-Gm-Message-State: AOJu0YxX+Si3mwryrmHaMxKNqDnVdaHg5tQNsxj+dsj5WobKU911Xhx+ P08HgpizAy+gRvdLOK65HaM+beWy8qAPd/bQ1Q8m84rMIJZA0XmK77ZP29daW5k= X-Google-Smtp-Source: AGHT+IF7DMs2N1O0IVGGMtrVRngCQqRx58CEUEwL0EQgeeKVizhe2O1tSrDeQaTz7DIsxKIolB78Hg== X-Received: by 2002:a5d:64c9:0:b0:371:844f:e0c with SMTP id ffacd0b85a97d-37cc246b3bamr1236159f8f.10.1727248519192; Wed, 25 Sep 2024 00:15:19 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc2c12b4sm3187911f8f.25.2024.09.25.00.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 00:15:18 -0700 (PDT) Date: Wed, 25 Sep 2024 10:15:13 +0300 From: Dan Carpenter To: Simon Horman Cc: Julia Lawall , Jinjie Ruan , Paolo Abeni , Jacob Keller , Tony Nguyen , linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Rafal Romanowski , netdev@vger.kernel.org Subject: Re: drivers/net/ethernet/intel/igb/igb_main.c:7895:6-11: ERROR: invalid reference to the index variable of the iterator on line 7890 (fwd) Message-ID: References: <20240923140125.GG3426578@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240923140125.GG3426578@kernel.org> On Mon, Sep 23, 2024 at 03:01:25PM +0100, Simon Horman wrote: > + Dan Carpenter, Rafal Romanowski, netdev > > On Fri, Sep 13, 2024 at 07:51:48PM +0200, Julia Lawall wrote: > > On line 7895, entry is never NULL, even if you are at the end (which is > > the same as the beginning) of the list. > > > > julia > > Hi Julia, all, > > Unless I am mistaken (it often happens) this is an issue > from about a year ago what was fixed within the same > time frame by Dan Carpenter in: > > - 4690aea589e7 ("igb: Fix an end of loop test") > https://git.kernel.org/netdev/net/c/4690aea589e7 > Yeah. It's weird that the zero day bot is flagging this as a new warning "branch date: 18 hours ago" when it was fixed last year. regards, dan carpenter