From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 242F1C433FE for ; Tue, 8 Nov 2022 09:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233621AbiKHJrI (ORCPT ); Tue, 8 Nov 2022 04:47:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233878AbiKHJrE (ORCPT ); Tue, 8 Nov 2022 04:47:04 -0500 Received: from nbd.name (nbd.name [46.4.11.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9404C2659; Tue, 8 Nov 2022 01:47:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:From :References:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Q6EAqK4s/7cGmHVEEsPDix9FO914oY737mNs8w3BHS8=; b=CYFdCN62GorZ0UJv0PxG4zSO/A EhNTC4JgHzgMTnYg+yuEiKQ7CaVoLnrvGSr5crxPcvCSf6WzI/HKWhGGIB+IqxLBAWwYWjIVSi98I 3auasouKGt0kggcRdSvR26KyjYKJMGUCHuxvZM2HzigZorcvOq2vqOnSw78gztEfHoVA=; Received: from p200300daa72ee1006d973cebf3767a25.dip0.t-ipconnect.de ([2003:da:a72e:e100:6d97:3ceb:f376:7a25] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1osLC3-000U5q-4f; Tue, 08 Nov 2022 10:46:55 +0100 Message-ID: Date: Tue, 8 Nov 2022 10:46:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Content-Language: en-US To: Vladimir Oltean Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org References: <20221107185452.90711-1-nbd@nbd.name> <20221107185452.90711-8-nbd@nbd.name> <20221107215745.ascdvnxqrbw4meuv@skbuf> <3b275dda-39ac-282d-8a46-d3a95fdfc766@nbd.name> <20221108090039.imamht5iyh2bbbnl@skbuf> <0948d841-b0eb-8281-455a-92f44586e0c0@nbd.name> <20221108094018.6cspe3mkh3hakxpd@skbuf> From: Felix Fietkau Subject: Re: [PATCH 08/14] net: vlan: remove invalid VLAN protocol warning In-Reply-To: <20221108094018.6cspe3mkh3hakxpd@skbuf> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 08.11.22 10:40, Vladimir Oltean wrote: > On Tue, Nov 08, 2022 at 10:20:44AM +0100, Felix Fietkau wrote: >> I need to look into how METADATA_HW_PORT_MUX works, but I think it could >> work. > > Could you please coordinate with Maxime to come up with something > common? Currently he proposes a generic "oob" tagger, while you propose > that we stay with the "mtk"/"qca" taggers, but they are taught to look > after offloaded metadata rather than in the packet. IMO your proposal > sounds better; the name of the tagging protocol is already exposed to > user space via /sys/class/net//dsa/tagging and therefore ABI. > It's just that we need a way to figure out how to make the flow > dissector and other layers not adjust for DSA header length if the DSA > tag is offloaded and not present in the packet. I think it depends on the hardware. If you can rely on the hardware always reporting the port out-of-band, a generic "oob" tagger would be fine. In my case, it depends on whether a second non-DSA ethernet MAC is active on the same device, so I do need to continue using the "mtk" tag driver. The flow dissector part is already solved: I simply used the existing .flow_dissect() tag op. - Felix