From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 748F93E491 for ; Tue, 23 Jan 2024 07:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705993922; cv=none; b=GRSsufZl9UGC5nAhdVHsUjdB6KIER0x5ozfJ33FGV5nEhg8q+kc4VC9N1ZKms5PczAyTHsP1qU2azuygNaTy1bJT+KA9/kqAyGOv87lVDfO3TU39o+h/7OB5Jb6BgMq+FB3ZaPO0c6sJnb3WUDiRUo/c2EKtZ10jtTwXg5oQAB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705993922; c=relaxed/simple; bh=8TLkKC95xxUcXS8HxMmhTHrmjiagTuWTnnP36E+JVpg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o7NJ3+RVfsBinx7dLJAMT4NyqBq4/DBWmUPK/edpHb17sh3Cr4r9ucAMDgb253EUVQeuzWpbtfnQ1kO7WMvbsL5MYztUbl/oy3DJsuZ8sYIPkLgQ2i6lmrmAQU50wXsDoQcRFTmVjgiFRIfma2nAEj6GaV2KmjSAwlg+8sz2Fcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=YVYH9Pdo; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="YVYH9Pdo" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705993918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yn0k9uMyZH7Ilmg0jV4IuHGUYfi2r0FQ3h6q1Wz25yY=; b=YVYH9PdoR8llDTT+DB6Tj43h3MzNQvuu+uxaM8J7+Axgl/yiErDO0gw7/fH3bE7nlMiWyp zZWPLzVE4Zl/X+xNfcq6f1wP9Jqe1UdlzG8IbCQ0lz69hATLS8r9pXPpigXfcj2cui8XG1 bbQI9TBfbesJfrz1PMoRhbmZcisiqEI= Date: Mon, 22 Jan 2024 23:11:51 -0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v17 11/14] bpf, net: switch to dynamic registration Content-Language: en-US To: thinker.li@gmail.com Cc: sinquersw@gmail.com, kuifeng@meta.com, netdev@vger.kernel.org, bpf@vger.kernel.org, ast@kernel.org, song@kernel.org, kernel-team@meta.com, andrii@kernel.org, drosen@google.com References: <20240119225005.668602-1-thinker.li@gmail.com> <20240119225005.668602-12-thinker.li@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20240119225005.668602-12-thinker.li@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/19/24 2:50 PM, thinker.li@gmail.com wrote: > @@ -1792,6 +1799,12 @@ static inline int bpf_trampoline_link_cgroup_shim(struct bpf_prog *prog, > static inline void bpf_trampoline_unlink_cgroup_shim(struct bpf_prog *prog) > { > } > +static inline int bpf_struct_ops_desc_init(struct bpf_struct_ops_desc *st_ops_desc, > + struct btf *btf, > + struct bpf_verifier_log *log) { > + return -EOPNOTSUPP; > +} > + This part still does not look right. It is under the "#if defined(CONFIG_CGROUP_BPF)...". No need to resend for now. I will try to adjust it unless I found other issues. Thanks.