From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56711C282C8 for ; Mon, 28 Jan 2019 08:37:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 096EA20881 for ; Mon, 28 Jan 2019 08:37:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="fWYbYPM3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbfA1Iht (ORCPT ); Mon, 28 Jan 2019 03:37:49 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:38983 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726744AbfA1Iht (ORCPT ); Mon, 28 Jan 2019 03:37:49 -0500 Received: by mail-lf1-f65.google.com with SMTP id n18so11175149lfh.6 for ; Mon, 28 Jan 2019 00:37:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ol45Is0aOfE50FI81hi/oDnDLp7+fLYp3L3ncg8Eh3g=; b=fWYbYPM3z7ozs8ZbEwcaxKN5z0hjRxZ4Twt9VxqpMXbBJI9edFeL8eXtafoBBZlrqK tVo40zebF8CbTMvN+49hDiBwF1xJdQFZpqjjS+jxibCRVojUS89gkhg+1/7rFc5rh/wZ 95K6dvl/TFvfFIEBbw6mmibcWRxKms6hTPOTZQH/i8L+KRxL+GCvSTmGkYoradfTmZ45 Fj/LZX6SpRmmtfKeS6bVlyZw8OfegnPr1bE3d0F6QClYVAcRMBUjOd5JJm3quSu9Jyfg eiYoeOruPmGLOrrPVft40KbVnBlYBW6ch3XBBC7VN+Ie0EKW7A6jCaVIl9kXL2IjhAg7 QbJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ol45Is0aOfE50FI81hi/oDnDLp7+fLYp3L3ncg8Eh3g=; b=H5MUlnUPXY+hRlgUHV/DIVi9rqYPtLvJ3Q3PMoGYh3Mi1LNQXgd4DF+/dAb2abSAYt r8gIAWnmrkyXRjv2qylprjeIfImFItAoaN7gXv5TCkm600wctT4jGiqS3RwStLwmBlx4 PZiBNa7gz1qcKKkudrSP3of1lnXq4U2pMImEb98kUuD4fDmCmx7tJNLVI3HVjHJqyZG9 c0SEYkO2otC3vF1eD3tgVv4e0T1umA8rTkEHYjhD5MqM780L4t22/zCTL+tyklvS/eFB N2udU30Or5wLnNNI7ZU1ENwNgdbgLlA2XMZMZjrBcUU9CKdmvMkzxj/JEBIl390vt6S5 wOkg== X-Gm-Message-State: AJcUukfpHl0+gOgTpa52a8m/ZQuq6/ja9Xhp+pQwDsPeO3jULNOAYoqw Uli9TUZiMN9lZ+Br/juhBW9Ha/r+3Zc= X-Google-Smtp-Source: ALg8bN61LxV3SnV51nzGFe+EphTMPOeJSWmyE6oCU/qs6WbFMItmCOFJnrY1ia0v4qlURpeaBzsz7A== X-Received: by 2002:a19:4345:: with SMTP id m5mr15526139lfj.142.1548664667139; Mon, 28 Jan 2019 00:37:47 -0800 (PST) Received: from [192.168.0.199] ([31.173.84.135]) by smtp.gmail.com with ESMTPSA id z64sm2732205lff.39.2019.01.28.00.37.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 00:37:46 -0800 (PST) Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix serdes irq setup going recursive To: Andrew Lunn , David Miller Cc: Vivien Didelot , netdev References: <20190127214800.4202-1-andrew@lunn.ch> From: Sergei Shtylyov Message-ID: Date: Mon, 28 Jan 2019 11:37:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190127214800.4202-1-andrew@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! On 28.01.2019 0:48, Andrew Lunn wrote: > Duec to a typo, mv88e6390_serdes_irq_setup() calls itself, rather than Due? > mv88e6390x_serdes_irq_setup(). It then blows the stack, and shortly > after the machine blows up. Never seen a stack overflow in the kernel... :-) > Fixes: 2defda1f4b91 ("net: dsa: mv88e6xxx: Add support for SERDES on ports 2-8 for 6390X") > Signed-off-by: Andrew Lunn MBR, Sergei