From: Florian Fainelli <f.fainelli@gmail.com>
To: "Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: "Rob Herring" <robh@kernel.org>,
"Alvin Šipraga" <ALSI@bang-olufsen.dk>,
"Linus Walleij" <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Olof Johansson" <olof@lixom.net>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: net: dsa: realtek-smi: convert to YAML schema
Date: Sun, 30 Jan 2022 09:35:39 -0800 [thread overview]
Message-ID: <a9571486-1efd-49a7-aa26-c582d493ead6@gmail.com> (raw)
In-Reply-To: <CAJq09z7n_RZpsZS+RNpdzzYzhiogHfWmfpOF5CJCLBL6gurS_Q@mail.gmail.com>
On 1/29/2022 12:52 PM, Luiz Angelo Daros de Luca wrote:
>> Why not turn realtek-smi.yaml into realtek.yaml which would also contain
>> information for the mdio interface? The things different with using MDIO
>> are that we don't use the [mdc,mdio,reset]-gpios properties and don't
>> handle the PHYs to the DSA ports. Couldn't you present these differences
>> on a single YAML file?
>
> Hello, Arinç
>
> realtek-mdio is an mdio driver with a couple of less properties. They
> do share a lot of stuff. But I don't know if I can fit the schema
> validation into a single file.
> YAML files are not simply documentation. They are used to validate DTS
> files. But that's still off-topic. Let's finish SMI version first and
> then discuss
> if the MDIO version should be standalone or merged with SMI.
Your YAML file can cover both types of electrical bus, what you are
defining is the layout and the properties of the Ethernet switch Device
Tree node which is exactly the same whether the switch is the children
of a SPI controller or the children of a MDIO bus controller. If there
are properties that only apply to SPI or MDIO, you can make use of
conditionals within the YAML file to enforce those. Having a single
binding file would be very helpful to make sure all eggs are in the same
basket.
--
Florian
next prev parent reply other threads:[~2022-01-30 17:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 7:26 [PATCH] dt-bindings: net: dsa: realtek-smi: convert to YAML schema Luiz Angelo Daros de Luca
2022-01-02 6:38 ` Linus Walleij
2022-01-04 23:44 ` Luiz Angelo Daros de Luca
2022-01-10 18:09 ` Rob Herring
2022-01-16 0:15 ` Linus Walleij
2022-01-10 18:20 ` Rob Herring
2022-01-29 16:02 ` Luiz Angelo Daros de Luca
2022-01-29 19:35 ` Arınç ÜNAL
2022-01-29 20:52 ` Luiz Angelo Daros de Luca
2022-01-30 17:35 ` Florian Fainelli [this message]
2022-01-31 0:49 ` Luiz Angelo Daros de Luca
2022-02-09 8:37 ` Luiz Angelo Daros de Luca
2022-02-09 15:28 ` Rob Herring
2022-02-09 16:49 ` Alvin Šipraga
2022-02-09 17:36 ` Andrew Lunn
2022-02-09 18:43 ` Luiz Angelo Daros de Luca
2022-02-09 18:55 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9571486-1efd-49a7-aa26-c582d493ead6@gmail.com \
--to=f.fainelli@gmail.com \
--cc=ALSI@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).