From: Andrew Lunn <andrew@lunn.ch>
To: kunwu.chan@linux.dev
Cc: trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com,
jlayton@kernel.org, neilb@suse.de, kolga@netapp.com,
Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Kunwu Chan <chentao@kylinos.cn>
Subject: Re: [PATCH] SUNRPC: Fix -Wformat-truncation warning
Date: Sat, 17 Aug 2024 00:01:03 +0200 [thread overview]
Message-ID: <a957b7bb-e5c2-480f-8f5c-2fa40637d8ba@lunn.ch> (raw)
In-Reply-To: <20240814093853.48657-1-kunwu.chan@linux.dev>
On Wed, Aug 14, 2024 at 05:38:53PM +0800, kunwu.chan@linux.dev wrote:
> From: Kunwu Chan <chentao@kylinos.cn>
>
> Increase size of the servername array to avoid truncated output warning.
>
> net/sunrpc/clnt.c:582:75: error:‘%s’ directive output may be truncated
> writing up to 107 bytes into a region of size 48
> [-Werror=format-truncation=]
> 582 | snprintf(servername, sizeof(servername), "%s",
> | ^~
>
> net/sunrpc/clnt.c:582:33: note:‘snprintf’ output
> between 1 and 108 bytes into a destination of size 48
> 582 | snprintf(servername, sizeof(servername), "%s",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 583 | sun->sun_path);
I think this has come up before, but i could be mis-remembering.
Please could you do a search for the discussion. The fact it is not
solved suggests to me it is not so simple to fix. Maybe there is some
protocol implications here.
Andrew
next prev parent reply other threads:[~2024-08-16 22:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 9:38 [PATCH] SUNRPC: Fix -Wformat-truncation warning kunwu.chan
2024-08-14 10:28 ` NeilBrown
2024-08-15 8:30 ` Kunwu Chan
2024-08-15 11:39 ` NeilBrown
2024-08-16 1:52 ` Kunwu Chan
2024-08-16 22:01 ` Andrew Lunn [this message]
2024-08-16 23:07 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a957b7bb-e5c2-480f-8f5c-2fa40637d8ba@lunn.ch \
--to=andrew@lunn.ch \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chentao@kylinos.cn \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=kunwu.chan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).