From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, vivien.didelot@savoirfairelinux.com,
davem@davemloft.net
Subject: Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support
Date: Tue, 4 Sep 2018 17:02:14 -0700 [thread overview]
Message-ID: <a96b5328-0d6f-d1bd-80dd-9b276dbce622@gmail.com> (raw)
In-Reply-To: <20180904231543.GI29121@lunn.ch>
On 09/04/2018 04:15 PM, Andrew Lunn wrote:
> On Tue, Sep 04, 2018 at 03:11:20PM -0700, Florian Fainelli wrote:
>> Add support for the Northstar Plus SerDes which is accessed through a
>> special page of the switch. Since this is something that most people
>> probably will not want to use, make it a configurable option.
>>
>> The SerDes supports both SGMII and 1000baseX modes, and is internally
>> looking like a seemingly standard MII PHY, except for the few bits that
>> got repurposed.
>
> Hi Florian
>
> The SERDES in the 6352 also look very similar to a standard MII PHYs.
>
> Maybe at some point, we should look at the SERDES drivers we have
> embedded in different MAC drivers, and see if we can pull them out,
> maybe put them in drivers/net/phy. Any SERDES driver being used in
> combination with phylink probably has the same API.
Yes, that would sound like a good move forward. The SerDes on the
Northstar Plus does have a bunch of MII standard registers, but not a
whole lot (BMSR, BMCR, MII_PHYSID1/2, AUTONEGADV, AUTONEGLPABIL) and
then, it's all custom.
It would be good to have possibly a third vendor (Mediatek? Qualcomm?)
and see how they did it so we can define an appropriate API.
--
Florian
next prev parent reply other threads:[~2018-09-05 4:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 22:11 [PATCH net-next 0/5] net: dsa: b53: SerDes support Florian Fainelli
2018-09-04 22:11 ` [PATCH net-next 1/5] net: dsa: b53: Add ability to enable/disable port interrupts Florian Fainelli
2018-09-04 22:11 ` [PATCH net-next 2/5] net: dsa: b53: Make SRAB driver manage " Florian Fainelli
2018-09-04 22:59 ` Andrew Lunn
2018-09-04 23:46 ` Florian Fainelli
2018-09-04 22:11 ` [PATCH net-next 3/5] net: dsa: b53: Add helper to set link parameters Florian Fainelli
2018-09-04 22:11 ` [PATCH net-next 4/5] net: dsa: b53: Add PHYLINK support Florian Fainelli
2018-09-04 22:11 ` [PATCH net-next 5/5] net: dsa: b53: Add SerDes support Florian Fainelli
2018-09-04 23:15 ` Andrew Lunn
2018-09-05 0:02 ` Florian Fainelli [this message]
2018-09-04 23:32 ` Andrew Lunn
2018-09-04 23:55 ` Florian Fainelli
2018-09-05 0:06 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a96b5328-0d6f-d1bd-80dd-9b276dbce622@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).