From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support Date: Tue, 4 Sep 2018 17:02:14 -0700 Message-ID: References: <20180904221120.13018-1-f.fainelli@gmail.com> <20180904221120.13018-6-f.fainelli@gmail.com> <20180904231543.GI29121@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, vivien.didelot@savoirfairelinux.com, davem@davemloft.net To: Andrew Lunn Return-path: Received: from mail-qk1-f195.google.com ([209.85.222.195]:45830 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbeIEE3w (ORCPT ); Wed, 5 Sep 2018 00:29:52 -0400 Received: by mail-qk1-f195.google.com with SMTP id z125-v6so3714957qkb.12 for ; Tue, 04 Sep 2018 17:02:24 -0700 (PDT) In-Reply-To: <20180904231543.GI29121@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/04/2018 04:15 PM, Andrew Lunn wrote: > On Tue, Sep 04, 2018 at 03:11:20PM -0700, Florian Fainelli wrote: >> Add support for the Northstar Plus SerDes which is accessed through a >> special page of the switch. Since this is something that most people >> probably will not want to use, make it a configurable option. >> >> The SerDes supports both SGMII and 1000baseX modes, and is internally >> looking like a seemingly standard MII PHY, except for the few bits that >> got repurposed. > > Hi Florian > > The SERDES in the 6352 also look very similar to a standard MII PHYs. > > Maybe at some point, we should look at the SERDES drivers we have > embedded in different MAC drivers, and see if we can pull them out, > maybe put them in drivers/net/phy. Any SERDES driver being used in > combination with phylink probably has the same API. Yes, that would sound like a good move forward. The SerDes on the Northstar Plus does have a bunch of MII standard registers, but not a whole lot (BMSR, BMCR, MII_PHYSID1/2, AUTONEGADV, AUTONEGLPABIL) and then, it's all custom. It would be good to have possibly a third vendor (Mediatek? Qualcomm?) and see how they did it so we can define an appropriate API. -- Florian