From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FD4720D517 for ; Tue, 4 Feb 2025 12:32:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738672364; cv=none; b=GVU8SA5uN+XD0+A8w41Teh3dSiclREztMwuMNOXEEFH4w3tkmQ3ii/EXPSdMKqvEhOi3LLWC3TxqoAp2pSzodO9AYSdQJnqPCAoBffeqLci1ALyYdlARZiBSTW8QxEdGUOBUcBPcfPYDIK1tHg3bVQhdNcjvi/YnQJucADHH+7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738672364; c=relaxed/simple; bh=ZXCyve0sUTK6c4XTKrMCSgDTrRmbMhPKy9Ob/dPEpwY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YoJFG/2J0lvcyrrZO+s5ZRb+UJgROKPJh+Y+xPECZpf19Gz8bmBKAgVA8LXo6bClMmzT+Owc85vZ/NFocv5oTq4cDDePTYsyWcCyPz2GI0DYMYLvD8pgovVXtHDmJVN/jotwcOPU1OxghtMYIOreHhU2Adkgcy7TwV3uNTPXqbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iECYI6A4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iECYI6A4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738672361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AX5LRiS12WNOF9SfYpl9HqapEpZa+Gag56j1GQy3/fs=; b=iECYI6A4Fkf1wj+zHcERNHLA8Z0Awzoz8kVoKGodWXidX/fTKbOCassp9LBDBjetctzPFZ Jc0ETO8pWT6sTgYHOp+WI6PBDzPY5tmJ4PxiZ/yC/JY3dGkdL8aFjJcGMNQ/U9wZ34JKVN MPukYJOwR6tFFSK93OD1X6JNe3M1Msk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-dYB8he6CPUSOhutUI4hoZA-1; Tue, 04 Feb 2025 07:32:40 -0500 X-MC-Unique: dYB8he6CPUSOhutUI4hoZA-1 X-Mimecast-MFC-AGG-ID: dYB8he6CPUSOhutUI4hoZA Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-385e00ebb16so2027785f8f.3 for ; Tue, 04 Feb 2025 04:32:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738672359; x=1739277159; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AX5LRiS12WNOF9SfYpl9HqapEpZa+Gag56j1GQy3/fs=; b=XEt70EDizfKgxSUXwnl8HFEdQCFDqbH5ZTo0jTYxasEEzpZ0DHXuJ0NVhhDl/Yuskl IcAXSEB1cSJCnA5Qkk+QTmuySm1YzI5ImYomjAWaX0MvzVNlh2SFArTKoEKZrY1L2kpT csGnrPuOYVxdRi0j3aSJsccKqVAyb6xAaxV3JEOPiOQE4i8f6As0THEUSNK3BNFM8jSj W3irO8C66yR/QgJtwyB6Y7Q3jYi+Cq7euz+fMrIgHppqirD/bvWd5tj9QWVEtvtfU2RI btEx4D9L+jtOmnYm2WvgxfvxZUcHkzQDN/Wbt4RCBkYZwjXKuEIB8eksj0tWR1pVKRuQ lRZQ== X-Forwarded-Encrypted: i=1; AJvYcCUIJhvci965trEFGcnjkxuESwb4/mhuuLOFT/cdHxRSnU/PYA3bpf1W6irGbB2PX8GGIqCLqgo=@vger.kernel.org X-Gm-Message-State: AOJu0YxKT904jj7V7o61Lwd/SjEhqXxISNMqDHKSa7FoO5hwgb/fpbGL L1hL1QCfjVcH4lr6GHHt4+JOyNraA6U6HOvTek3abx2OrJYbJ0193aXbdzgyY5GLPXCpMPBRuB3 EknRcYN+C+1woQS+HgnQOQwjesw/IClHqOnWTyDHuNZXtHwN27rgjhw== X-Gm-Gg: ASbGncuIWvexFnwEprliW/y185b0NfFjkVtY3p8o635GK/9qPoKeH+koeMuYcxf4ey7 o1pz+/Gwi01PHDqoeNbtUVXBA+uR5V0Qh1k3nnhKOLdz4KhJuiniNpv5K1BkaK24j9UD8KYJT4E rCsVN5oIW+WtNqhJn9j/XvF7QMTTGRFMoiwJ7mfzKMonkQKeK6Gzzu6E1/CgwVcNT2DlKqcyiXo OsL0Hfic6/if6uaCGTgu2BdVrH06CS1hHRAYYXrOTsmMa/+W1k+cDLnxj8T2eBROy6Z6OfWnpF5 9HeJhZX7aWtK/XJMSO+oAOqeaj4y/xTs82E= X-Received: by 2002:a5d:6c63:0:b0:38b:ef2b:422 with SMTP id ffacd0b85a97d-38c52096052mr20648852f8f.36.1738672359125; Tue, 04 Feb 2025 04:32:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IET/fdmBxwT2kEgeJ6xq9QXxCTtWqsruKoqpBh7wylvEdA7HYKJAa2oNIfrVb0R3o0Sw7rwuw== X-Received: by 2002:a5d:6c63:0:b0:38b:ef2b:422 with SMTP id ffacd0b85a97d-38c52096052mr20648813f8f.36.1738672358717; Tue, 04 Feb 2025 04:32:38 -0800 (PST) Received: from [192.168.88.253] (146-241-41-201.dyn.eolo.it. [146.241.41.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438dcc263f0sm222469255e9.9.2025.02.04.04.32.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2025 04:32:38 -0800 (PST) Message-ID: Date: Tue, 4 Feb 2025 13:32:36 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 0/6] Device memory TCP TX To: Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kselftest@vger.kernel.org Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Simon Horman , Jonathan Corbet , Andrew Lunn , Neal Cardwell , David Ahern , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Stefan Hajnoczi , Stefano Garzarella , Shuah Khan , sdf@fomichev.me, asml.silence@gmail.com, dw@davidwei.uk, Jamal Hadi Salim , Victor Nogueira , Pedro Tammela , Samiullah Khawaja References: <20250203223916.1064540-1-almasrymina@google.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250203223916.1064540-1-almasrymina@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/3/25 11:39 PM, Mina Almasry wrote: > The TX path had been dropped from the Device Memory TCP patch series > post RFCv1 [1], to make that series slightly easier to review. This > series rebases the implementation of the TX path on top of the > net_iov/netmem framework agreed upon and merged. The motivation for > the feature is thoroughly described in the docs & cover letter of the > original proposal, so I don't repeat the lengthy descriptions here, but > they are available in [1]. > > Sending this series as RFC as the winder closure is immenient. I plan on > reposting as non-RFC once the tree re-opens, addressing any feedback > I receive in the meantime. I guess you should drop this paragraph. > Full outline on usage of the TX path is detailed in the documentation > added in the first patch. > > Test example is available via the kselftest included in the series as well. > > The series is relatively small, as the TX path for this feature largely > piggybacks on the existing MSG_ZEROCOPY implementation. It looks like no additional device level support is required. That is IMHO so good up to suspicious level :) > Patch Overview: > --------------- > > 1. Documentation & tests to give high level overview of the feature > being added. > > 2. Add netmem refcounting needed for the TX path. > > 3. Devmem TX netlink API. > > 4. Devmem TX net stack implementation. It looks like even the above section needs some update. /P