From: Eric Dumazet <eric.dumazet@gmail.com>
To: Li RongQing <lirongqing@baidu.com>, netdev@vger.kernel.org
Subject: Re: [PATCH][next-next][v2] netlink: avoid to allocate full skb when sending to many devices
Date: Thu, 20 Sep 2018 06:43:32 -0700 [thread overview]
Message-ID: <a9b4a4b9-04c4-bf55-3f08-b7889524374a@gmail.com> (raw)
In-Reply-To: <1537433690-24335-1-git-send-email-lirongqing@baidu.com>
On 09/20/2018 01:54 AM, Li RongQing wrote:
> if skb->head is vmalloc address, when this skb is delivered, full
> allocation for this skb is required, if there are many devices,
> the full allocation will be called for every devices
>
> now if it is vmalloc, allocate a new skb, whose data is not vmalloc
> address, and use new allocated skb to clone and send, to avoid to
> allocate full skb everytime.
>
> Signed-off-by: Zhang Yu <zhangyu31@baidu.com>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
This looks a broken Signed-off-by chain to me.
Who really wrote this patch ?
Also, given that I gave feedback to your first version,
it is customary to CC me for future versions, unless you want me to not notice them.
And lastly this patch looks way too complicated to me.
You probably can write something much simpler.
Thanks.
next prev parent reply other threads:[~2018-09-20 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 8:54 [PATCH][next-next][v2] netlink: avoid to allocate full skb when sending to many devices Li RongQing
2018-09-20 13:43 ` Eric Dumazet [this message]
2018-09-20 13:51 ` Eric Dumazet
2018-09-21 3:27 ` 答复: " Li,Rongqing
2018-09-21 14:54 ` Eric Dumazet
2018-09-21 19:08 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9b4a4b9-04c4-bf55-3f08-b7889524374a@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).