Re: [PATCH v9 net-next 2/5] psp: add new netlink cmd for dev-assoc and dev-disassoc

[Daniel Zahka <daniel.zahka@gmail.com>]

On 3/30/26 6:31 PM, Wei Wang wrote:
> +    -
> +      name: dev-assoc
> +      doc: Associate a network device with a PSP device.
> +      attribute-set: dev
> +      do:
> +        request:
> +          attributes:
> +            - id
> +            - ifindex
> +            - nsid
> +        reply:
> +          attributes: []
> +        pre: psp-device-get-locked
> +        post: psp-device-unlock
> +    -
> +      name: dev-disassoc
> +      doc: Disassociate a network device from a PSP device.
> +      attribute-set: dev
> +      do:
> +        request:
> +          attributes:
> +            - id
> +            - ifindex
> +            - nsid
> +        reply:
> +          attributes: []
> +        pre: psp-device-get-locked
> +        post: psp-device-unlock
>   

Not sure where we ended up on the netns isolation model, but I'll just 
note that these ops are not "admin" so they can be done from any netns. 
I don't think that's an issue per se, but I wonder if someone with a 
different use case will come along down the road and want to go for the 
more restrictive deployment option.

>   
> +	list_for_each_entry_safe(entry, entry_tmp, &psd->assoc_dev_list,
> +				 dev_list) {
> +		list_del(&entry->dev_list);
> +		rcu_assign_pointer(entry->assoc_dev->psp_dev, NULL);
> +		netdev_put(entry->assoc_dev, &entry->dev_tracker);
> +		kfree(entry);
> +	}
> +
>   	rcu_assign_pointer(psd->main_netdev->psp_dev, NULL);
>   
>   	psd->ops = NULL;
> @@ -361,5 +381,4 @@ static int __init psp_init(void)
>   
>   	return genl_register_family(&psp_nl_family);
>   }
> -
>   subsys_initcall(psp_init);

nit: spurious line deletion

> +int psp_nl_dev_assoc_doit(struct sk_buff *skb, struct genl_info *info)
> +{
> +	struct psp_dev *psd = info->user_ptr[0];
> +	struct psp_assoc_dev *psp_assoc_dev;
> +	struct net_device *assoc_dev;
> +	u32 assoc_ifindex;
> +	struct sk_buff *rsp;

nit: reverse xmas issue

> +
> +int psp_nl_dev_disassoc_doit(struct sk_buff *skb, struct genl_info *info)
> +{
> +	struct psp_assoc_dev *entry, *found = NULL;
> +	struct psp_dev *psd = info->user_ptr[0];
> +	u32 assoc_ifindex;
> +	struct sk_buff *rsp;

nit: reverse xmas issue