From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B991C43381 for ; Mon, 18 Feb 2019 16:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39730214DA for ; Mon, 18 Feb 2019 16:22:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="jH2fXfU5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733095AbfBRQWR (ORCPT ); Mon, 18 Feb 2019 11:22:17 -0500 Received: from lelv0142.ext.ti.com ([198.47.23.249]:42828 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730659AbfBRQWQ (ORCPT ); Mon, 18 Feb 2019 11:22:16 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x1IGM6q2090183; Mon, 18 Feb 2019 10:22:06 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1550506926; bh=INLNfmfSwceeFyLka/80I1hvvHF700rywDdDnSZO+7M=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=jH2fXfU5zryRif580ii8Xd/2aWLvANHV75lOjCWq2Sn40wtBg71gWVJt2Eg9IJJNL Ep6bD7WsQSXWFrNt99UtWzLpHnD8Y6CQN/lQUuZJ9YG8gR3EMtzSIiSyLTJiekpBsJ oPssrZ17lShHxli99v+O59Lhl6CEsOaaWTxVY7kc= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x1IGM6S3065590 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 18 Feb 2019 10:22:06 -0600 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 18 Feb 2019 10:22:06 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 18 Feb 2019 10:22:06 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x1IGM36H017998; Mon, 18 Feb 2019 10:22:03 -0600 Subject: Re: [PATCH 0/2] ARM: dts: am335x-evm/evmsk: Fix PHY mode for ethernet To: Tony Lindgren CC: , , , , , , , , , , References: <20190218143629.28392-1-peter.ujfalusi@ti.com> <20190218144430.GE15711@atomide.com> From: Peter Ujfalusi Message-ID: Date: Mon, 18 Feb 2019 18:22:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190218144430.GE15711@atomide.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/02/2019 16.44, Tony Lindgren wrote: > * Peter Ujfalusi [190218 14:36]: >> Hi, >> >> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke the >> ethernet networking on evmsk (and most likely on the evm as well): >> https://patchwork.ozlabs.org/patch/1028527/ >> >> v1 patch to fix the situation: >> https://patchwork.ozlabs.org/patch/1040617/ >> >> It turned out that the at803x driver is actually broken and need to be fixed >> along with the DT data. >> >> The following series is proposed to fix the driver: >> https://patchwork.ozlabs.org/project/netdev/list/?series=92611 >> >> but the PHT mode needs to be switched to rgmii-id from rgmii-txid: >> The rx delay is enabled by default and the driver never disabled it so when >> asking rgmii-txid it actually got rgmii-id. >> >> The patch can be backported to stable, I have tested that it is not causing >> regression with the old, broken driver. > > Can the dts changes be merged before the driver changes or > does it cause the phy to stop working? The phy is not working atm, but this change will not cause regression even if it is merged first. > > Regards, > > Tony > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki