From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] net/ipv6: Do not allow device only routes via the multipath API Date: Fri, 13 Jul 2018 10:45:15 -0400 Message-ID: References: <20180712214823.6917-1-dsahern@kernel.org> <20180713132845.64854ff3@epycfail> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com To: Stefano Brivio , dsahern@kernel.org Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:43802 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729643AbeGMPAQ (ORCPT ); Fri, 13 Jul 2018 11:00:16 -0400 Received: by mail-pl0-f67.google.com with SMTP id o7-v6so1921720plk.10 for ; Fri, 13 Jul 2018 07:45:20 -0700 (PDT) In-Reply-To: <20180713132845.64854ff3@epycfail> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 7/13/18 7:28 AM, Stefano Brivio wrote: > On Thu, 12 Jul 2018 14:48:23 -0700 > dsahern@kernel.org wrote: > >> @@ -4388,6 +4388,13 @@ static int ip6_route_multipath_add(struct fib6_config *cfg, >> rt = NULL; >> goto cleanup; >> } >> + if (!rt6_qualify_for_ecmp(rt)) { >> + err = EINVAL; > > Shouldn't this be -EINVAL, just for consistency? E.g. we might return a > -ENOMEM from ip6_route_info_append(), etc. > oops, yes, missing the '-'. thanks for catching that.