From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Dave Marquardt <davemarq@linux.ibm.com>
Cc: netdev@vger.kernel.org, michal.swiatkowski@linux.intel.com,
horms@kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net-next v3 1/3] net: ibmveth: Indented struct ibmveth_adapter correctly
Date: Thu, 17 Apr 2025 09:44:32 +0200 [thread overview]
Message-ID: <aACxYGS9F8bh5PkG@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250416205751.66365-2-davemarq@linux.ibm.com>
On Wed, Apr 16, 2025 at 03:57:49PM -0500, Dave Marquardt wrote:
> Made struct ibmveth_adapter follow indentation rules
>
> Signed-off-by: Dave Marquardt <davemarq@linux.ibm.com>
> ---
> drivers/net/ethernet/ibm/ibmveth.h | 64 +++++++++++++++---------------
> 1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmveth.h b/drivers/net/ethernet/ibm/ibmveth.h
> index 8468e2c59d7a..0f72ce54e7cf 100644
> --- a/drivers/net/ethernet/ibm/ibmveth.h
> +++ b/drivers/net/ethernet/ibm/ibmveth.h
> @@ -134,38 +134,38 @@ struct ibmveth_rx_q {
> };
>
> struct ibmveth_adapter {
> - struct vio_dev *vdev;
> - struct net_device *netdev;
> - struct napi_struct napi;
> - unsigned int mcastFilterSize;
> - void * buffer_list_addr;
> - void * filter_list_addr;
> - void *tx_ltb_ptr[IBMVETH_MAX_QUEUES];
> - unsigned int tx_ltb_size;
> - dma_addr_t tx_ltb_dma[IBMVETH_MAX_QUEUES];
> - dma_addr_t buffer_list_dma;
> - dma_addr_t filter_list_dma;
> - struct ibmveth_buff_pool rx_buff_pool[IBMVETH_NUM_BUFF_POOLS];
> - struct ibmveth_rx_q rx_queue;
> - int rx_csum;
> - int large_send;
> - bool is_active_trunk;
> -
> - u64 fw_ipv6_csum_support;
> - u64 fw_ipv4_csum_support;
> - u64 fw_large_send_support;
> - /* adapter specific stats */
> - u64 replenish_task_cycles;
> - u64 replenish_no_mem;
> - u64 replenish_add_buff_failure;
> - u64 replenish_add_buff_success;
> - u64 rx_invalid_buffer;
> - u64 rx_no_buffer;
> - u64 tx_map_failed;
> - u64 tx_send_failed;
> - u64 tx_large_packets;
> - u64 rx_large_packets;
> - /* Ethtool settings */
> + struct vio_dev *vdev;
> + struct net_device *netdev;
> + struct napi_struct napi;
> + unsigned int mcastFilterSize;
> + void *buffer_list_addr;
> + void *filter_list_addr;
> + void *tx_ltb_ptr[IBMVETH_MAX_QUEUES];
> + unsigned int tx_ltb_size;
> + dma_addr_t tx_ltb_dma[IBMVETH_MAX_QUEUES];
> + dma_addr_t buffer_list_dma;
> + dma_addr_t filter_list_dma;
> + struct ibmveth_buff_pool rx_buff_pool[IBMVETH_NUM_BUFF_POOLS];
> + struct ibmveth_rx_q rx_queue;
> + int rx_csum;
> + int large_send;
> + bool is_active_trunk;
> +
> + u64 fw_ipv6_csum_support;
> + u64 fw_ipv4_csum_support;
> + u64 fw_large_send_support;
> + /* adapter specific stats */
> + u64 replenish_task_cycles;
> + u64 replenish_no_mem;
> + u64 replenish_add_buff_failure;
> + u64 replenish_add_buff_success;
> + u64 rx_invalid_buffer;
> + u64 rx_no_buffer;
> + u64 tx_map_failed;
> + u64 tx_send_failed;
> + u64 tx_large_packets;
> + u64 rx_large_packets;
> + /* Ethtool settings */
> u8 duplex;
> u32 speed;
> };
> --
> 2.49.0
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
next prev parent reply other threads:[~2025-04-17 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 20:57 [PATCH net-next v3 0/3] net: ibmveth: Make ibmveth use new reset function and new KUnit tests Dave Marquardt
2025-04-16 20:57 ` [PATCH net-next v3 1/3] net: ibmveth: Indented struct ibmveth_adapter correctly Dave Marquardt
2025-04-17 7:44 ` Michal Swiatkowski [this message]
2025-04-22 12:20 ` Simon Horman
2025-04-16 20:57 ` [PATCH net-next v3 2/3] net: ibmveth: Reset the adapter when unexpected states are detected Dave Marquardt
2025-04-17 7:48 ` Michal Swiatkowski
2025-04-22 12:20 ` Simon Horman
2025-04-23 1:15 ` Jakub Kicinski
2025-04-16 20:57 ` [PATCH net-next v3 3/3] net: ibmveth: added KUnit tests for some buffer pool functions Dave Marquardt
2025-04-22 12:21 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aACxYGS9F8bh5PkG@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=davemarq@linux.ibm.com \
--cc=horms@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).