From: Stanislav Fomichev <stfomichev@gmail.com>
To: Mina Almasry <almasrymina@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
jdamato@fastly.com, sdf@fomichev.me, ap420073@gmail.com
Subject: Re: [PATCH net] net: fix the missing unlock for detached devices
Date: Fri, 18 Apr 2025 07:14:10 -0700 [thread overview]
Message-ID: <aAJeMtRlBIMGfdN2@mini-arch> (raw)
In-Reply-To: <CAHS8izMnK0C0sQpK+5NoL-ETNjJ+6BUhx_Bgq9drViUaic+W1A@mail.gmail.com>
On 04/18, Mina Almasry wrote:
> On Thu, Apr 17, 2025 at 6:53 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > The combined condition was left as is when we converted
> > from __dev_get_by_index() to netdev_get_by_index_lock().
> > There was no need to undo anything with the former, for
> > the latter we need an unlock.
> >
> > Fixes: 1d22d3060b9b ("net: drop rtnl_lock for queue_mgmt operations")
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> Reviewed-by: Mina Almasry <almasrymina@google.com>
Mina, the same (unlock netedev on !present) needs to happen for
https://lore.kernel.org/netdev/20250417231540.2780723-5-almasrymina@google.com/
Presumably you'll do another repost at some point?
next prev parent reply other threads:[~2025-04-18 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 1:53 [PATCH net] net: fix the missing unlock for detached devices Jakub Kicinski
2025-04-18 11:51 ` Mina Almasry
2025-04-18 14:14 ` Stanislav Fomichev [this message]
2025-04-18 20:38 ` Mina Almasry
2025-04-21 15:24 ` Stanislav Fomichev
2025-04-22 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAJeMtRlBIMGfdN2@mini-arch \
--to=stfomichev@gmail.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).