Re: [PATCH net] net: fix the missing unlock for detached devices

[Stanislav Fomichev <stfomichev@gmail.com>]

On 04/18, Mina Almasry wrote:
> On Fri, Apr 18, 2025 at 7:14 AM Stanislav Fomichev <stfomichev@gmail.com> wrote:
> >
> > On 04/18, Mina Almasry wrote:
> > > On Thu, Apr 17, 2025 at 6:53 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > > >
> > > > The combined condition was left as is when we converted
> > > > from __dev_get_by_index() to netdev_get_by_index_lock().
> > > > There was no need to undo anything with the former, for
> > > > the latter we need an unlock.
> > > >
> > > > Fixes: 1d22d3060b9b ("net: drop rtnl_lock for queue_mgmt operations")
> > > > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > >
> > > Reviewed-by: Mina Almasry <almasrymina@google.com>
> >
> > Mina, the same (unlock netedev on !present) needs to happen for
> > https://lore.kernel.org/netdev/20250417231540.2780723-5-almasrymina@google.com/
> >
> > Presumably you'll do another repost at some point?
> 
> Yes, and there is also a lot going on in that series outside of this
> locking point. If the rest of the series looks good and is merged I
> can also look into porting this fix to the tx path as a follow up, if
> acceptable.

I'd be surprised if the maintainers gonna pull buggy code :-) Why not
repost with a fix? It's a three lines change.