From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, "Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, "Simon Horman" <horms@kernel.org>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>
Subject: Re: [PATCH net 3/3] net: stmmac: socfpga: Remove unused pcs-mdiodev field
Date: Tue, 22 Apr 2025 11:26:40 +0100 [thread overview]
Message-ID: <aAdu4EGoVMMUzsXb@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250422094701.49798-4-maxime.chevallier@bootlin.com>
On Tue, Apr 22, 2025 at 11:46:57AM +0200, Maxime Chevallier wrote:
> When dwmac-socfpga was converted to using the Lynx PCS (previously
> referred to in the driver as the Altera TSE PCS), the
> lynx_pcs_create_mdiodev() was used to create the pcs instance.
>
> As this function didn't exist in the early versions of the series, a
> local mdiodev object was stored for PCS creation. It was never used, but
> still made it into the driver, so remove it.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2025-04-22 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 9:46 [PATCH net 0/3] net: stmmac: socfpga: 1000BaseX support and cleanups Maxime Chevallier
2025-04-22 9:46 ` [PATCH net 1/3] net: stmmac: socfpga: Enable internal GMII when using 1000BaseX Maxime Chevallier
2025-04-22 10:23 ` Russell King (Oracle)
2025-04-22 9:46 ` [PATCH net 2/3] net: stmmac: socfpga: Don't check for phy to enable the SGMII adapter Maxime Chevallier
2025-04-22 10:26 ` Russell King (Oracle)
2025-04-22 11:54 ` Maxime Chevallier
2025-04-22 9:46 ` [PATCH net 3/3] net: stmmac: socfpga: Remove unused pcs-mdiodev field Maxime Chevallier
2025-04-22 10:26 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAdu4EGoVMMUzsXb@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexis.lothore@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).