From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C3CF29AAE1; Tue, 22 Apr 2025 20:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745353267; cv=none; b=LbqmeDgOdeDtFTOihxEYWUBajuUPaE1gQWyfHpP1yW77RoRC7H9cSDovIHf5AwUZ1vRZBdPG6B8W9RrT8YVl/ZQJVaxw4h9n2uHZ/oxKU2mXtpwwGykvvEExEWI2N0iSPEEBlEnF6nsfurhbwaQ3n3y4vxNlX30OVL7d8+GpNvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745353267; c=relaxed/simple; bh=CS7AKF/9vLtf/TyeLql6jdatBRJcEof29RHJq/23Jog=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J02mU8NjMrOfFzOxbn+TVQpjPEfRF6McfVYI0kGXq0Lb0Fa+NoawFD+9XKnDA9RLL0eNrnyFL1xkQzshKoSrTMSKSz6e35lN5AJXcdO9loKV4IorSwUGmvSdl4Kl2UiV9FLEaFTGEm5qNlBCrPVYJa4q+rxxVrUIKoyf8mRdVFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=h2QGGRsn; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="h2QGGRsn" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=T+6cHpd/27XGOPMFydca7fk610QISCEGPK2+n0P8YDM=; b=h2QGGRsnQ9gaBZ+OcdcyJxrwEJ H0uZvJY1p2AAy1KxNcFffKkp1A8h0pF3M1z+0DMaNZOl5coJD7+Fn3Mneg+CI0DnPM/FKyHs+ItfZ yYSqLtx7A6rjZ0xcZXjdQQ4Q2wmKGplUvjavR7/9zmtlVrzmfNF8PuyuJOIOtmGeoegOYFr7APmDr /Q2JaE4tcSvHcTWESIfpFIEmcSqzO9Z6U3j9aV52cz/DdzbYrbzcAQtHAAWNMpYs5Pm7E43v3U3Ga 49jcfd9X9E1r1X7ChmTHicF7OEPY3RyKodXf5+rO+5SoBG7jeCuWG0t417BCtY+EgNJq1uLchbNoJ 19XS1GbQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58702) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u7K6w-0004yU-11; Tue, 22 Apr 2025 21:20:54 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1u7K6s-0007mx-3B; Tue, 22 Apr 2025 21:20:51 +0100 Date: Tue, 22 Apr 2025 21:20:50 +0100 From: "Russell King (Oracle)" To: Simon Horman Cc: Justin Chen , netdev@vger.kernel.org, devicetree@vger.kernel.org, rafal@milecki.pl, hkallweit1@gmail.com, bcm-kernel-feedback-list@broadcom.com, opendmb@gmail.com, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch, florian.fainelli@broadcom.com Subject: Re: [PATCH net-next 3/5] net: bcmasp: Remove support for asp-v2.0 Message-ID: References: <20250416224815.2863862-1-justin.chen@broadcom.com> <20250416224815.2863862-4-justin.chen@broadcom.com> <20250422183235.GN2843373@horms.kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250422183235.GN2843373@horms.kernel.org> Sender: Russell King (Oracle) On Tue, Apr 22, 2025 at 07:32:35PM +0100, Simon Horman wrote: > On Wed, Apr 16, 2025 at 03:48:13PM -0700, Justin Chen wrote: > > The SoC that supported asp-v2.0 never saw the light of day. asp-v2.0 has > > quirks that makes the logic overly complicated. For example, asp-v2.0 is > > the only revision that has a different wake up IRQ hook up. Remove asp-v2.0 > > support to make supporting future HW revisions cleaner. > > > > Signed-off-by: Justin Chen > > --- > > drivers/net/ethernet/broadcom/asp2/bcmasp.c | 98 ++----------------- > > drivers/net/ethernet/broadcom/asp2/bcmasp.h | 45 ++------- > > .../ethernet/broadcom/asp2/bcmasp_ethtool.c | 21 +--- > > .../net/ethernet/broadcom/asp2/bcmasp_intf.c | 2 +- > > .../ethernet/broadcom/asp2/bcmasp_intf_defs.h | 3 +- > > 5 files changed, 23 insertions(+), 146 deletions(-) > > > > diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c > > ... > > > static const struct bcmasp_plat_data v21_plat_data = { > > - .init_wol = bcmasp_init_wol_shared, > > - .enable_wol = bcmasp_enable_wol_shared, > > - .destroy_wol = bcmasp_wol_irq_destroy_shared, > > .core_clock_select = bcmasp_core_clock_select_one, > > - .hw_info = &v21_hw_info, > > + .eee_fixup = NULL; > > .eee_fixup = NULL, Even better... omit it entirely. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!