From: Danilo Krummrich <dakr@kernel.org>
To: Philipp Stanner <phasta@kernel.org>
Cc: "Lyude Paul" <lyude@redhat.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Sabrina Dubroca" <sd@queasysnail.net>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v2 2/2] drm/nouveau: nouveau_fence: Standardize list iterations
Date: Wed, 23 Apr 2025 17:26:54 +0200 [thread overview]
Message-ID: <aAkGvpIL7KiRH-iO@pollux> (raw)
In-Reply-To: <20250415121900.55719-4-phasta@kernel.org>
On Tue, Apr 15, 2025 at 02:19:01PM +0200, Philipp Stanner wrote:
> nouveau_fence.c iterates over lists in a non-canonical way. Since the
> operations done are just basic for-each-loops, they should be written in
> the standard form.
>
> Use for_each_safe() instead of the custom loop iterations.
Please use list_for_each_entry_safe() instead.
You only need resend this patch, I will pick patch 1 for -fixes; this one goes
into -next.
- Danilo
prev parent reply other threads:[~2025-04-23 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 12:18 [PATCH v2 0/2] drm/nouveau: Don't set signaled fences' error codes Philipp Stanner
2025-04-15 12:19 ` [PATCH v2 1/2] drm/nouveau: Fix WARN_ON in nouveau_fence_context_kill() Philipp Stanner
2025-04-23 15:54 ` Danilo Krummrich
2025-04-15 12:19 ` [PATCH v2 2/2] drm/nouveau: nouveau_fence: Standardize list iterations Philipp Stanner
2025-04-15 12:28 ` Christian König
2025-04-23 15:26 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAkGvpIL7KiRH-iO@pollux \
--to=dakr@kernel.org \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=phasta@kernel.org \
--cc=sd@queasysnail.net \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).