netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Amery Hung <ameryhung@gmail.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
	alexei.starovoitov@gmail.com, andrii@kernel.org,
	daniel@iogearbox.net, martin.lau@kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH bpf-next/net] bpf: net_sched: Fix using bpf qdisc as default qdisc
Date: Wed, 23 Apr 2025 16:20:22 -0700	[thread overview]
Message-ID: <aAl1tm5rwB0kq1/Y@pop-os.localdomain> (raw)
In-Reply-To: <20250422225808.3900221-1-ameryhung@gmail.com>

On Tue, Apr 22, 2025 at 03:58:08PM -0700, Amery Hung wrote:
> Use bpf_try_module_get()/bpf_module_put() instead of try_module_get()/
> module_put() when handling default qdisc since users can assign a bpf
> qdisc to it.
> 
> To trigger the bug:
> $ bpftool struct_ops register bpf_qdisc_fq.bpf.o /sys/fs/bpf
> $ echo bpf_fq > /proc/sys/net/core/default_qdisc
> 

Good to see eBPF Qdisc's can be default as well.

> Fixes: c8240344956e (bpf: net_sched: Support implementation of Qdisc_ops in bpf)
> Signed-off-by: Amery Hung <ameryhung@gmail.com>

Acked-by: Cong Wang <xiyou.wangcong@gmail.com>

Thanks!

  reply	other threads:[~2025-04-23 23:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 22:58 [PATCH bpf-next/net] bpf: net_sched: Fix using bpf qdisc as default qdisc Amery Hung
2025-04-23 23:20 ` Cong Wang [this message]
2025-04-29 17:29 ` Martin KaFai Lau
2025-04-29 17:37   ` Amery Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAl1tm5rwB0kq1/Y@pop-os.localdomain \
    --to=xiyou.wangcong@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=ameryhung@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@meta.com \
    --cc=martin.lau@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).