Re: [mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[Salvatore Bonaccorso <carnil@debian.org>]

Hi Michal,

On Fri, Apr 11, 2025 at 10:48:44PM +0200, AsciiWolf wrote:
> Please note that as pointed out in my previous emails, the binary
> provides seems to be required for console-application component type.
> 
> Daniel
> 
> pá 11. 4. 2025 v 22:18 odesílatel AsciiWolf <mail@asciiwolf.com> napsal:
> 
> >
> > Here is the proposed fix. It is validated using appstreamcli validate
> > and should work without issues.
> >
> > --- org.kernel.software.network.ethtool.metainfo.xml_orig
> > 2025-03-31 00:46:03.000000000 +0200
> > +++ org.kernel.software.network.ethtool.metainfo.xml    2025-04-11
> > 22:14:11.634355310 +0200
> > @@ -1,5 +1,5 @@
> >  <?xml version="1.0" encoding="UTF-8"?>
> > -<component type="desktop">
> > +<component type="console-application">
> >    <id>org.kernel.software.network.ethtool</id>
> >    <metadata_license>MIT</metadata_license>
> >    <name>ethtool</name>
> > @@ -11,6 +11,7 @@
> >    </description>
> >    <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
> >    <provides>
> > +    <binary>ethtool</binary>
> >      <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
> >    </provides>
> >  </component>
> >
> > Regards,
> > Daniel Rusek

Is there anything else you need from us here? Or are you waiting for
us for a git am'able patch? If Daniel Rusek prefers to not submit one,
I can re-iterate with the required changes my proposal 
https://lore.kernel.org/netdev/20250411141023.14356-2-carnil@debian.org/
with the needed changes.

We would like to apply the change in downstream Debian fwiw, but only
with the variant accepted by upstream.

Regards,
Salvatore