Re: [PATCH] tools/Makefile: Add ynl target

[Joe Damato <jdamato@fastly.com>]

On Thu, Apr 24, 2025 at 11:17:34AM +0100, Donald Hunter wrote:
> Joe Damato <jdamato@fastly.com> writes:
> 
> > Add targets to build, clean, and install ynl headers, libynl.a, and
> > python tooling.
> >
> > Signed-off-by: Joe Damato <jdamato@fastly.com>
> > ---
> >  tools/Makefile | 16 +++++++++++++---
> >  1 file changed, 13 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/Makefile b/tools/Makefile
> > index 5e1254eb66de..c31cbbd12c45 100644
> > --- a/tools/Makefile
> > +++ b/tools/Makefile
> > @@ -41,6 +41,7 @@ help:
> >  	@echo '  mm                     - misc mm tools'
> >  	@echo '  wmi			- WMI interface examples'
> >  	@echo '  x86_energy_perf_policy - Intel energy policy tool'
> > +	@echo '  ynl			- ynl headers, library, and python tool'
> >  	@echo ''
> >  	@echo 'You can do:'
> >  	@echo ' $$ make -C tools/ <tool>_install'
> > @@ -118,11 +119,14 @@ freefall: FORCE
> >  kvm_stat: FORCE
> >  	$(call descend,kvm/$@)
> >  
> > +ynl: FORCE
> > +	$(call descend,net/ynl)
> > +
> >  all: acpi counter cpupower gpio hv firewire \
> >  		perf selftests bootconfig spi turbostat usb \
> >  		virtio mm bpf x86_energy_perf_policy \
> >  		tmon freefall iio objtool kvm_stat wmi \
> > -		debugging tracing thermal thermometer thermal-engine
> > +		debugging tracing thermal thermometer thermal-engine ynl
> >  
> >  acpi_install:
> >  	$(call descend,power/$(@:_install=),install)
> > @@ -157,13 +161,16 @@ freefall_install:
> >  kvm_stat_install:
> >  	$(call descend,kvm/$(@:_install=),install)
> >  
> > +ynl_install:
> > +	$(call descend,net/$(@:_install=),install)
> 
> nit: I'm not sure there's any merit in the $(@:_install=) construct,
> when it's only really needed when there are multiple targets in the same
> rule. For ynl_install, $(call descend,net/ynl,install) would be just
> fine. It's funny that the existing convention in this Makefile is to
> mostly use substitution for the _install rules, but literals for the
> _clean rules.

That's right, I was trying to follow convention. I agree with what
you said. If the maintainer of whichever tree this goes into would
prefer that I re-spin this, I am happy to do so. I was mostly trying
to keep it consistent with the existing targets.

> Either way:
> 
> Reviewed-by: Donald Hunter <donald.hunter@gmail.com>

Thanks!