[PATCH net-next] tools: ynl: fix the header guard name for OVPN

[PATCH net-next] tools: ynl: fix the header guard name for OVPN

[Jakub Kicinski]

Thorsten reports that after upgrading system headers from linux-next
the YNL build breaks. I typo'ed the header guard, _H is missing.

Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Link: https://lore.kernel.org/59ba7a94-17b9-485f-aa6d-14e4f01a7a39@leemhuis.info
Fixes: 12b196568a3a ("tools: ynl: add missing header deps")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: donald.hunter@gmail.com
CC: jacob.e.keller@intel.com
CC: danieller@nvidia.com
CC: sdf@fomichev.me
---
 tools/net/ynl/Makefile.deps | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps
index 8b7bf673b686..a5e6093903fb 100644
--- a/tools/net/ynl/Makefile.deps
+++ b/tools/net/ynl/Makefile.deps
@@ -27,7 +27,7 @@ CFLAGS_netdev:=$(call get_hdr_inc,_LINUX_NETDEV_H,netdev.h)
 CFLAGS_nl80211:=$(call get_hdr_inc,__LINUX_NL802121_H,nl80211.h)
 CFLAGS_nlctrl:=$(call get_hdr_inc,__LINUX_GENERIC_NETLINK_H,genetlink.h)
 CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_NETLINK_H,nfsd_netlink.h)
-CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN,ovpn.h)
+CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN_H,ovpn.h)
 CFLAGS_ovs_datapath:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
 CFLAGS_ovs_flow:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
 CFLAGS_ovs_vport:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
-- 
2.49.0

RE: [PATCH net-next] tools: ynl: fix the header guard name for OVPN

[Keller, Jacob E]

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Wednesday, April 23, 2025 3:03 PM
> To: davem@davemloft.net
> Cc: netdev@vger.kernel.org; Dumazet, Eric <edumazet@google.com>;
> pabeni@redhat.com; andrew+netdev@lunn.ch; horms@kernel.org; Jakub Kicinski
> <kuba@kernel.org>; Thorsten Leemhuis <linux@leemhuis.info>;
> donald.hunter@gmail.com; Keller, Jacob E <jacob.e.keller@intel.com>;
> danieller@nvidia.com; sdf@fomichev.me
> Subject: [PATCH net-next] tools: ynl: fix the header guard name for OVPN
> 
> Thorsten reports that after upgrading system headers from linux-next
> the YNL build breaks. I typo'ed the header guard, _H is missing.
> 
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Link: https://lore.kernel.org/59ba7a94-17b9-485f-aa6d-
> 14e4f01a7a39@leemhuis.info
> Fixes: 12b196568a3a ("tools: ynl: add missing header deps")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: jacob.e.keller@intel.com
> CC: danieller@nvidia.com
> CC: sdf@fomichev.me
> ---
>  tools/net/ynl/Makefile.deps | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps
> index 8b7bf673b686..a5e6093903fb 100644
> --- a/tools/net/ynl/Makefile.deps
> +++ b/tools/net/ynl/Makefile.deps
> @@ -27,7 +27,7 @@ CFLAGS_netdev:=$(call
> get_hdr_inc,_LINUX_NETDEV_H,netdev.h)
>  CFLAGS_nl80211:=$(call get_hdr_inc,__LINUX_NL802121_H,nl80211.h)
>  CFLAGS_nlctrl:=$(call get_hdr_inc,__LINUX_GENERIC_NETLINK_H,genetlink.h)
>  CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_NETLINK_H,nfsd_netlink.h)
> -CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN,ovpn.h)
> +CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN_H,ovpn.h)
>  CFLAGS_ovs_datapath:=$(call
> get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
>  CFLAGS_ovs_flow:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
>  CFLAGS_ovs_vport:=$(call
> get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
> --
> 2.49.0

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Re: [PATCH net-next] tools: ynl: fix the header guard name for OVPN

[Thorsten Leemhuis]

On 24.04.25 00:02, Jakub Kicinski wrote:
> I typo'ed the header guard, _H is missing.

Ha, happens, thx for fixing this so quickly!

> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>

Tested-by: Thorsten Leemhuis <linux@leemhuis.info>

Ciao, Thorsten

Re: [PATCH net-next] tools: ynl: fix the header guard name for OVPN

[Joe Damato]

On Wed, Apr 23, 2025 at 03:02:31PM -0700, Jakub Kicinski wrote:
> Thorsten reports that after upgrading system headers from linux-next
> the YNL build breaks. I typo'ed the header guard, _H is missing.
> 
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Link: https://lore.kernel.org/59ba7a94-17b9-485f-aa6d-14e4f01a7a39@leemhuis.info
> Fixes: 12b196568a3a ("tools: ynl: add missing header deps")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: jacob.e.keller@intel.com
> CC: danieller@nvidia.com
> CC: sdf@fomichev.me
> ---
>  tools/net/ynl/Makefile.deps | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Joe Damato <jdamato@fastly.com>

Re: [PATCH net-next] tools: ynl: fix the header guard name for OVPN

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 23 Apr 2025 15:02:31 -0700 you wrote:
> Thorsten reports that after upgrading system headers from linux-next
> the YNL build breaks. I typo'ed the header guard, _H is missing.
> 
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Link: https://lore.kernel.org/59ba7a94-17b9-485f-aa6d-14e4f01a7a39@leemhuis.info
> Fixes: 12b196568a3a ("tools: ynl: add missing header deps")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net-next] tools: ynl: fix the header guard name for OVPN
    https://git.kernel.org/netdev/net-next/c/f74d14a7dfb1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html