* [PATCH net-next] tools: ynl: fix the header guard name for OVPN
@ 2025-04-23 22:02 Jakub Kicinski
2025-04-23 22:49 ` Keller, Jacob E
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Jakub Kicinski @ 2025-04-23 22:02 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski,
Thorsten Leemhuis, donald.hunter, jacob.e.keller, danieller, sdf
Thorsten reports that after upgrading system headers from linux-next
the YNL build breaks. I typo'ed the header guard, _H is missing.
Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Link: https://lore.kernel.org/59ba7a94-17b9-485f-aa6d-14e4f01a7a39@leemhuis.info
Fixes: 12b196568a3a ("tools: ynl: add missing header deps")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: donald.hunter@gmail.com
CC: jacob.e.keller@intel.com
CC: danieller@nvidia.com
CC: sdf@fomichev.me
---
tools/net/ynl/Makefile.deps | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps
index 8b7bf673b686..a5e6093903fb 100644
--- a/tools/net/ynl/Makefile.deps
+++ b/tools/net/ynl/Makefile.deps
@@ -27,7 +27,7 @@ CFLAGS_netdev:=$(call get_hdr_inc,_LINUX_NETDEV_H,netdev.h)
CFLAGS_nl80211:=$(call get_hdr_inc,__LINUX_NL802121_H,nl80211.h)
CFLAGS_nlctrl:=$(call get_hdr_inc,__LINUX_GENERIC_NETLINK_H,genetlink.h)
CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_NETLINK_H,nfsd_netlink.h)
-CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN,ovpn.h)
+CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN_H,ovpn.h)
CFLAGS_ovs_datapath:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
CFLAGS_ovs_flow:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
CFLAGS_ovs_vport:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
--
2.49.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH net-next] tools: ynl: fix the header guard name for OVPN
2025-04-23 22:02 [PATCH net-next] tools: ynl: fix the header guard name for OVPN Jakub Kicinski
@ 2025-04-23 22:49 ` Keller, Jacob E
2025-04-24 8:41 ` Thorsten Leemhuis
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Keller, Jacob E @ 2025-04-23 22:49 UTC (permalink / raw)
To: Jakub Kicinski, davem@davemloft.net
Cc: netdev@vger.kernel.org, Dumazet, Eric, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, Thorsten Leemhuis,
donald.hunter@gmail.com, danieller@nvidia.com, sdf@fomichev.me
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Wednesday, April 23, 2025 3:03 PM
> To: davem@davemloft.net
> Cc: netdev@vger.kernel.org; Dumazet, Eric <edumazet@google.com>;
> pabeni@redhat.com; andrew+netdev@lunn.ch; horms@kernel.org; Jakub Kicinski
> <kuba@kernel.org>; Thorsten Leemhuis <linux@leemhuis.info>;
> donald.hunter@gmail.com; Keller, Jacob E <jacob.e.keller@intel.com>;
> danieller@nvidia.com; sdf@fomichev.me
> Subject: [PATCH net-next] tools: ynl: fix the header guard name for OVPN
>
> Thorsten reports that after upgrading system headers from linux-next
> the YNL build breaks. I typo'ed the header guard, _H is missing.
>
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Link: https://lore.kernel.org/59ba7a94-17b9-485f-aa6d-
> 14e4f01a7a39@leemhuis.info
> Fixes: 12b196568a3a ("tools: ynl: add missing header deps")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: jacob.e.keller@intel.com
> CC: danieller@nvidia.com
> CC: sdf@fomichev.me
> ---
> tools/net/ynl/Makefile.deps | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps
> index 8b7bf673b686..a5e6093903fb 100644
> --- a/tools/net/ynl/Makefile.deps
> +++ b/tools/net/ynl/Makefile.deps
> @@ -27,7 +27,7 @@ CFLAGS_netdev:=$(call
> get_hdr_inc,_LINUX_NETDEV_H,netdev.h)
> CFLAGS_nl80211:=$(call get_hdr_inc,__LINUX_NL802121_H,nl80211.h)
> CFLAGS_nlctrl:=$(call get_hdr_inc,__LINUX_GENERIC_NETLINK_H,genetlink.h)
> CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_NETLINK_H,nfsd_netlink.h)
> -CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN,ovpn.h)
> +CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN_H,ovpn.h)
> CFLAGS_ovs_datapath:=$(call
> get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
> CFLAGS_ovs_flow:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
> CFLAGS_ovs_vport:=$(call
> get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
> --
> 2.49.0
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] tools: ynl: fix the header guard name for OVPN
2025-04-23 22:02 [PATCH net-next] tools: ynl: fix the header guard name for OVPN Jakub Kicinski
2025-04-23 22:49 ` Keller, Jacob E
@ 2025-04-24 8:41 ` Thorsten Leemhuis
2025-04-24 16:47 ` Joe Damato
2025-04-25 19:01 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Thorsten Leemhuis @ 2025-04-24 8:41 UTC (permalink / raw)
To: Jakub Kicinski, davem
Cc: netdev, edumazet, pabeni, andrew+netdev, horms, donald.hunter,
jacob.e.keller, danieller, sdf
On 24.04.25 00:02, Jakub Kicinski wrote:
> I typo'ed the header guard, _H is missing.
Ha, happens, thx for fixing this so quickly!
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Tested-by: Thorsten Leemhuis <linux@leemhuis.info>
Ciao, Thorsten
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] tools: ynl: fix the header guard name for OVPN
2025-04-23 22:02 [PATCH net-next] tools: ynl: fix the header guard name for OVPN Jakub Kicinski
2025-04-23 22:49 ` Keller, Jacob E
2025-04-24 8:41 ` Thorsten Leemhuis
@ 2025-04-24 16:47 ` Joe Damato
2025-04-25 19:01 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Joe Damato @ 2025-04-24 16:47 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms,
Thorsten Leemhuis, donald.hunter, jacob.e.keller, danieller, sdf
On Wed, Apr 23, 2025 at 03:02:31PM -0700, Jakub Kicinski wrote:
> Thorsten reports that after upgrading system headers from linux-next
> the YNL build breaks. I typo'ed the header guard, _H is missing.
>
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Link: https://lore.kernel.org/59ba7a94-17b9-485f-aa6d-14e4f01a7a39@leemhuis.info
> Fixes: 12b196568a3a ("tools: ynl: add missing header deps")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: jacob.e.keller@intel.com
> CC: danieller@nvidia.com
> CC: sdf@fomichev.me
> ---
> tools/net/ynl/Makefile.deps | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Joe Damato <jdamato@fastly.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] tools: ynl: fix the header guard name for OVPN
2025-04-23 22:02 [PATCH net-next] tools: ynl: fix the header guard name for OVPN Jakub Kicinski
` (2 preceding siblings ...)
2025-04-24 16:47 ` Joe Damato
@ 2025-04-25 19:01 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-25 19:01 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms, linux,
donald.hunter, jacob.e.keller, danieller, sdf
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 23 Apr 2025 15:02:31 -0700 you wrote:
> Thorsten reports that after upgrading system headers from linux-next
> the YNL build breaks. I typo'ed the header guard, _H is missing.
>
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Link: https://lore.kernel.org/59ba7a94-17b9-485f-aa6d-14e4f01a7a39@leemhuis.info
> Fixes: 12b196568a3a ("tools: ynl: add missing header deps")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net-next] tools: ynl: fix the header guard name for OVPN
https://git.kernel.org/netdev/net-next/c/f74d14a7dfb1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-04-25 19:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-23 22:02 [PATCH net-next] tools: ynl: fix the header guard name for OVPN Jakub Kicinski
2025-04-23 22:49 ` Keller, Jacob E
2025-04-24 8:41 ` Thorsten Leemhuis
2025-04-24 16:47 ` Joe Damato
2025-04-25 19:01 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).