Re: [PATCH net-next] rtase: Modify the format specifier in snprintf to %u.

[Joe Damato <jdamato@fastly.com>]

On Thu, Apr 24, 2025 at 02:27:46PM +0800, Justin Lai wrote:
> Modify the format specifier in snprintf to %u.
> 
> Fixes: ea244d7d8dce ("rtase: Implement the .ndo_open function")
> Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> ---
>  drivers/net/ethernet/realtek/rtase/rtase_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> index 8c902eaeb5ec..5996b13572c9 100644
> --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> @@ -1114,7 +1114,7 @@ static int rtase_open(struct net_device *dev)
>  		/* request other interrupts to handle multiqueue */
>  		for (i = 1; i < tp->int_nums; i++) {
>  			ivec = &tp->int_vector[i];
> -			snprintf(ivec->name, sizeof(ivec->name), "%s_int%i",
> +			snprintf(ivec->name, sizeof(ivec->name), "%s_int%u",
>  				 tp->dev->name, i);
>  			ret = request_irq(ivec->irq, rtase_q_interrupt, 0,
>  					  ivec->name, ivec);

Same comment as the other patch: not sure if there is a bug out in
the wild for this (seems unlikely since i is u16), so I think this
is cleanup for net-next despite having a Fixes.

Reviewed-by: Joe Damato <jdamato@fastly.com>