* [PATCH net-next] rtase: Modify the format specifier in snprintf to %u.
@ 2025-04-24 6:27 Justin Lai
2025-04-24 17:00 ` Joe Damato
0 siblings, 1 reply; 2+ messages in thread
From: Justin Lai @ 2025-04-24 6:27 UTC (permalink / raw)
To: kuba
Cc: davem, edumazet, pabeni, andrew+netdev, linux-kernel, netdev,
horms, pkshih, larry.chiu, Justin Lai
Modify the format specifier in snprintf to %u.
Fixes: ea244d7d8dce ("rtase: Implement the .ndo_open function")
Signed-off-by: Justin Lai <justinlai0215@realtek.com>
---
drivers/net/ethernet/realtek/rtase/rtase_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
index 8c902eaeb5ec..5996b13572c9 100644
--- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
+++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
@@ -1114,7 +1114,7 @@ static int rtase_open(struct net_device *dev)
/* request other interrupts to handle multiqueue */
for (i = 1; i < tp->int_nums; i++) {
ivec = &tp->int_vector[i];
- snprintf(ivec->name, sizeof(ivec->name), "%s_int%i",
+ snprintf(ivec->name, sizeof(ivec->name), "%s_int%u",
tp->dev->name, i);
ret = request_irq(ivec->irq, rtase_q_interrupt, 0,
ivec->name, ivec);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] rtase: Modify the format specifier in snprintf to %u.
2025-04-24 6:27 [PATCH net-next] rtase: Modify the format specifier in snprintf to %u Justin Lai
@ 2025-04-24 17:00 ` Joe Damato
0 siblings, 0 replies; 2+ messages in thread
From: Joe Damato @ 2025-04-24 17:00 UTC (permalink / raw)
To: Justin Lai
Cc: kuba, davem, edumazet, pabeni, andrew+netdev, linux-kernel,
netdev, horms, pkshih, larry.chiu
On Thu, Apr 24, 2025 at 02:27:46PM +0800, Justin Lai wrote:
> Modify the format specifier in snprintf to %u.
>
> Fixes: ea244d7d8dce ("rtase: Implement the .ndo_open function")
> Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> ---
> drivers/net/ethernet/realtek/rtase/rtase_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> index 8c902eaeb5ec..5996b13572c9 100644
> --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> @@ -1114,7 +1114,7 @@ static int rtase_open(struct net_device *dev)
> /* request other interrupts to handle multiqueue */
> for (i = 1; i < tp->int_nums; i++) {
> ivec = &tp->int_vector[i];
> - snprintf(ivec->name, sizeof(ivec->name), "%s_int%i",
> + snprintf(ivec->name, sizeof(ivec->name), "%s_int%u",
> tp->dev->name, i);
> ret = request_irq(ivec->irq, rtase_q_interrupt, 0,
> ivec->name, ivec);
Same comment as the other patch: not sure if there is a bug out in
the wild for this (seems unlikely since i is u16), so I think this
is cleanup for net-next despite having a Fixes.
Reviewed-by: Joe Damato <jdamato@fastly.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-24 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-24 6:27 [PATCH net-next] rtase: Modify the format specifier in snprintf to %u Justin Lai
2025-04-24 17:00 ` Joe Damato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox