From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1B0549620 for ; Fri, 25 Apr 2025 01:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745545128; cv=none; b=KgtlHEjSCyBBwQvZW3kGwLsiAt17+4KVXjZCmWwo5LvrXs+/u2ifPSjw9mUCoiklRGkVerRLqvlNBI8nZYv6fz4EMLpksmXIK0lKq5Q0Em9jtPEEHIjPMfcJqJIQGl7F2ezIlqGWa+2R87OoVbiIAEMsnXsLs5rw4HFDsuoutng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745545128; c=relaxed/simple; bh=yhOlAEzwrF0aCAFf+JgQeNbbx3sk62jQPHuNFSORMuE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VQ1O+rwvPFMo+8buFNMXs+6oxfJyuqx0hqEy3qA+ybCwOAw3h+8H1vs7bPRdHGMzNL8o1Ahnx2MsYMZpLFCGJXwnSNX47RpoIO2laO08RdOdaBvVEXKP6t7YxH53R7C6IZ6OnZRroPq5fEHG2YBc8lzLVZjldVjRC9eS+0sz0qE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=OWV7qZ91; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="OWV7qZ91" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-227a8cdd241so23363665ad.3 for ; Thu, 24 Apr 2025 18:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1745545126; x=1746149926; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=KSqYScKgytFmXzzaTTv95GQdkzPtmJIkcWKivQdfd7E=; b=OWV7qZ91iqDuT+nIndMTN3+mLDvFqvm0SPifYoT0vQYv6e23u7mATuF35l0sbtfaSh DU4aAksXg8kTxuXwwZUmp+NimBiZo4FM4b8iadkqnYuayNakFFl7Wcpo6xN7e4Y/mRb9 GpIY4wlgGvsZaRjRmgqZVlA631Kso9qMhnLf0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745545126; x=1746149926; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KSqYScKgytFmXzzaTTv95GQdkzPtmJIkcWKivQdfd7E=; b=lRgzVSKIlbo7OInTfrNauJuQW+cpZvzmQfpVmVJVrjQHH+r5Qz/e+YqNFoRCCOz06u +uEHOjdIMjyeWr5U0XOjYCuZt4vsPatpCpLvvuOzPtt7reOsYrjbf3ZsaNZWRAo2fDbk AcKNvucOS/RvamGYXfHIwYQM1zMU94hPMyVtmYJmfUn2jz9am+vaVRVWi/e5Q72//bcf 5/8lwtdrLZ/T/u9OA2RszmlI9mZ3wRYUX5NVgsMhezQGZo1hKlUQCk+xu6vhzHOuEtni UPTQD/Wj/MJ3syL10ubdBvo8JdbTYJyObT/ie5tl7nzG2HjB1vMADupe4dnhyGTImxe0 LSOQ== X-Gm-Message-State: AOJu0YwdwUKaq0P904Rxhf+yAh8LWIBKDzoJ5g+GaAcKvX+N9GLkABHW vYy7B2wMe5/oW0gimLxvEVcv/rndUTc3ReR90IfitdzEryHleHP+d2sWPUHLldo= X-Gm-Gg: ASbGncuh+wn7xkfe7uC0jLrHXXyDm5kPT3jmXVZcZ6Utv3zxRaUcsooDv5nAaG1Y18d To4njz7+Qad1diwxoRhzdltqDL22FB+rlkVguQb3B/Rea3KYbfuFP+E7x4k8M/WTirY6+fJWp87 VGi75jlQTmLVFAw1wy/OA74DzjVl3LHvWxzEeIagz3PAZhYfGWmEvhvLQb0HihHjxcUu5lc8uob sq0DYo3QZ/kWh/ht163hg7tVUZiMEOgo030AaZ3rrc3B2hPzKgBdChfVhFbTs1EnMXdZUx+mDbH l59VfoTBmpwIXzZXaNKmlt35yDYODXxylP5riDT0LfCALKCNlHkYQiTS8IWJt1+5NQQLgjizIMn Ww6tERG+C2Pw8QUkKaA== X-Google-Smtp-Source: AGHT+IHtyY/Uad+Dw4YYDrHqlH0t+QCAu2yareuHTx9iQsFmiei7axjBQ/X+aTouMtAFce8aEB6OZQ== X-Received: by 2002:a17:902:e84c:b0:216:644f:bc0e with SMTP id d9443c01a7336-22dbf5efce5mr8556365ad.24.1745545126067; Thu, 24 Apr 2025 18:38:46 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52214ebsm20612495ad.246.2025.04.24.18.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 18:38:45 -0700 (PDT) Date: Thu, 24 Apr 2025 18:38:42 -0700 From: Joe Damato To: Jakub Kicinski Cc: netdev@vger.kernel.org, shaw.leon@gmail.com, pabeni@redhat.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , open list , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:XDP (eXpress Data Path):Keyword:(?:b|_)xdp(?:b|_)" Subject: Re: [PATCH net-next v4 2/3] selftests: drv-net: Factor out ksft C helpers Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , netdev@vger.kernel.org, shaw.leon@gmail.com, pabeni@redhat.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , open list , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:XDP (eXpress Data Path):Keyword:(?:b|_)xdp(?:b|_)" References: <20250424002746.16891-1-jdamato@fastly.com> <20250424002746.16891-3-jdamato@fastly.com> <20250424183218.204e9fd1@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424183218.204e9fd1@kernel.org> On Thu, Apr 24, 2025 at 06:32:18PM -0700, Jakub Kicinski wrote: > On Thu, 24 Apr 2025 00:27:32 +0000 Joe Damato wrote: > > +++ b/tools/testing/selftests/drivers/net/ksft.h > > +static void ksft_ready(void) > > > +static void ksft_wait(void) > > These need to be static inlines. > I'll fix when applying cause I think this series may conflict > with Bui Quang Minh's OK -- if you change your mind and prefer that I respin to save you some cycles or something, I am happy to do so. Thanks.